Introduce struct MediaConfig, with construction-time settings.

talk/app/webrtc/fakemediacontroller.h

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 12 matching lines @@
  * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
  * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef TALK_APP_WEBRTC_FAKEMEDIACONTROLLER_H_
 #define TALK_APP_WEBRTC_FAKEMEDIACONTROLLER_H_
 
 #include "talk/app/webrtc/mediacontroller.h"
 #include "webrtc/base/checks.h"
+#include "webrtc/media/base/mediachannel.h"
 
 namespace cricket {
 
 class FakeMediaController : public webrtc::MediaControllerInterface {
  public:
   explicit FakeMediaController(cricket::ChannelManager* channel_manager,
                                webrtc::Call* call)
       : channel_manager_(channel_manager), call_(call) {
     RTC_DCHECK(nullptr != channel_manager_);
     RTC_DCHECK(nullptr != call_);
   }
   ~FakeMediaController() override {}
   webrtc::Call* call_w() override { return call_; }
   cricket::ChannelManager* channel_manager() const override {
     return channel_manager_;
   }
+  const MediaConfig& config() const override {
+    static const MediaConfig media_config = MediaConfig();

[perkj_webrtc, 2016/02/09 15:35:37]

nit: add as a member instead.

[nisse-webrtc, 2016/02/10 08:53:00]

I can do that, but in my opinion, a local definition is more readable.

Update: I tried it, and C++ doesn't like me... I want this object to be
statically allocated read-only data, set to the default values specified in the
declaration of the MediaConfig struct. So I wrote 

 private:
  static const MediaConfig media_config_ = MediaConfig();

I write the initializer "= MediaConfig()" because I want it properly initialized
with default values (do I get that if I drop the initializer?). And then the
compiler complains, "in-class initializer for static data member of type 'const
cricket::MediaConfig' requires 'constexpr' specifier". But I don't want any
fancy compile-time computation, I just want an initializer equivalent to writing
"= { false, true, false }" in C.

+    return media_config;
+  }
 
  private:
   cricket::ChannelManager* channel_manager_;
   webrtc::Call* call_;
 };
 }  // namespace cricket
 #endif  // TALK_APP_WEBRTC_FAKEMEDIACONTROLLER_H_