Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1670123002: Set VideoReceiveStream members in init list. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set VideoReceiveStream members in init list. Removes scoped_ptrs and resets, preventing some heap allocation but also overall showing that these objects won't be reconstructed on the fly. BUG=webrtc:5494 R=stefan@webrtc.org Committed: https://crrev.com/f751bf867923502574c7f8ca9fe2f103b0ab99f7 Cr-Commit-Position: refs/heads/master@{#11503}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove GetRemoteBitrateEstimator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -75 lines) Patch
M webrtc/video/video_receive_stream.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 10 chunks +74 lines, -72 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-05 10:28:17 UTC) #1
stefan-webrtc
lgtm with comment addressed https://codereview.webrtc.org/1670123002/diff/1/webrtc/video/video_receive_stream.cc File webrtc/video/video_receive_stream.cc (right): https://codereview.webrtc.org/1670123002/diff/1/webrtc/video/video_receive_stream.cc#newcode397 webrtc/video/video_receive_stream.cc:397: } Remove this and change ...
4 years, 10 months ago (2016-02-05 12:50:36 UTC) #2
pbos-webrtc
remove GetRemoteBitrateEstimator
4 years, 10 months ago (2016-02-05 12:57:57 UTC) #3
pbos-webrtc
https://codereview.webrtc.org/1670123002/diff/1/webrtc/video/video_receive_stream.cc File webrtc/video/video_receive_stream.cc (right): https://codereview.webrtc.org/1670123002/diff/1/webrtc/video/video_receive_stream.cc#newcode397 webrtc/video/video_receive_stream.cc:397: } On 2016/02/05 12:50:36, stefan-webrtc (holmer) wrote: > Remove ...
4 years, 10 months ago (2016-02-05 12:58:04 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f751bf867923502574c7f8ca9fe2f103b0ab99f7 Cr-Commit-Position: refs/heads/master@{#11503}
4 years, 10 months ago (2016-02-05 13:01:03 UTC) #7
pbos-webrtc
4 years, 10 months ago (2016-02-05 13:01:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f751bf867923502574c7f8ca9fe2f103b0ab99f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698