Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Side by Side Diff: talk/app/webrtc/webrtcsession.h

Issue 1669993003: Remove deprecated PeerConnectionObserver::OnStateChange and OnIceComplete (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/peerconnectioninterface_unittest.cc ('k') | talk/app/webrtc/webrtcsession.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 // Called any time the IceConnectionState changes 89 // Called any time the IceConnectionState changes
90 // TODO(honghaiz): Change the name to OnIceConnectionStateChange so as to 90 // TODO(honghaiz): Change the name to OnIceConnectionStateChange so as to
91 // conform to the w3c standard. 91 // conform to the w3c standard.
92 virtual void OnIceConnectionChange( 92 virtual void OnIceConnectionChange(
93 PeerConnectionInterface::IceConnectionState new_state) {} 93 PeerConnectionInterface::IceConnectionState new_state) {}
94 // Called any time the IceGatheringState changes 94 // Called any time the IceGatheringState changes
95 virtual void OnIceGatheringChange( 95 virtual void OnIceGatheringChange(
96 PeerConnectionInterface::IceGatheringState new_state) {} 96 PeerConnectionInterface::IceGatheringState new_state) {}
97 // New Ice candidate have been found. 97 // New Ice candidate have been found.
98 virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0; 98 virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0;
99 // All Ice candidates have been found.
100 // TODO(bemasc): Remove this once callers transition to OnIceGatheringChange.
101 // (via PeerConnectionObserver)
102 virtual void OnIceComplete() {}
103 99
104 // Called whenever the state changes between receiving and not receiving. 100 // Called whenever the state changes between receiving and not receiving.
105 virtual void OnIceConnectionReceivingChange(bool receiving) {} 101 virtual void OnIceConnectionReceivingChange(bool receiving) {}
106 102
107 protected: 103 protected:
108 ~IceObserver() {} 104 ~IceObserver() {}
109 105
110 private: 106 private:
111 RTC_DISALLOW_COPY_AND_ASSIGN(IceObserver); 107 RTC_DISALLOW_COPY_AND_ASSIGN(IceObserver);
112 }; 108 };
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
517 PeerConnectionInterface::BundlePolicy bundle_policy_; 513 PeerConnectionInterface::BundlePolicy bundle_policy_;
518 514
519 // Declares the RTCP mux policy for the WebRTCSession. 515 // Declares the RTCP mux policy for the WebRTCSession.
520 PeerConnectionInterface::RtcpMuxPolicy rtcp_mux_policy_; 516 PeerConnectionInterface::RtcpMuxPolicy rtcp_mux_policy_;
521 517
522 RTC_DISALLOW_COPY_AND_ASSIGN(WebRtcSession); 518 RTC_DISALLOW_COPY_AND_ASSIGN(WebRtcSession);
523 }; 519 };
524 } // namespace webrtc 520 } // namespace webrtc
525 521
526 #endif // TALK_APP_WEBRTC_WEBRTCSESSION_H_ 522 #endif // TALK_APP_WEBRTC_WEBRTCSESSION_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/peerconnectioninterface_unittest.cc ('k') | talk/app/webrtc/webrtcsession.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698