Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: webrtc/video/vie_channel.cc

Issue 1669623004: Use CallStats for RTT in Call, rather than VideoSendStream::GetRtt() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Cleanup Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/video/vie_channel.h ('K') | « webrtc/video/vie_channel.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/vie_channel.cc
diff --git a/webrtc/video/vie_channel.cc b/webrtc/video/vie_channel.cc
index 7c13a7c3dfbbcdd88e13540aab3987e531203f26..835536f53ab4d1e68a41055c7f5095867832a4a3 100644
--- a/webrtc/video/vie_channel.cc
+++ b/webrtc/video/vie_channel.cc
@@ -112,7 +112,6 @@ ViEChannel::ViEChannel(uint32_t number_of_cores,
nack_history_size_sender_(kMinSendSidePacketHistorySize),
max_nack_reordering_threshold_(kMaxPacketAgeToNack),
pre_render_callback_(NULL),
- report_block_stats_sender_(new ReportBlockStats()),
time_of_first_rtt_ms_(-1),
rtt_sum_ms_(0),
last_rtt_ms_(0),
@@ -220,11 +219,6 @@ void ViEChannel::UpdateHistograms() {
"WebRTC.Video.UniqueNackRequestsReceivedInPercent",
rtcp_counter.UniqueNackRequestsInPercent());
}
- int fraction_lost = report_block_stats_sender_->FractionLostInPercent();
- if (fraction_lost != -1) {
- RTC_HISTOGRAM_PERCENTAGE("WebRTC.Video.SentPacketsLostInPercent",
- fraction_lost);
- }
}
StreamDataCounters rtp;
@@ -732,53 +726,6 @@ int32_t ViEChannel::GetRemoteRTCPCName(char rtcp_cname[]) {
return rtp_rtcp_modules_[0]->RemoteCNAME(remoteSSRC, rtcp_cname);
}
-int32_t ViEChannel::GetSendRtcpStatistics(uint16_t* fraction_lost,
- uint32_t* cumulative_lost,
- uint32_t* extended_max,
- uint32_t* jitter_samples,
- int64_t* rtt_ms) {
- // Aggregate the report blocks associated with streams sent on this channel.
- std::vector<RTCPReportBlock> report_blocks;
- for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_)
- rtp_rtcp->RemoteRTCPStat(&report_blocks);
-
- if (report_blocks.empty())
- return -1;
-
- uint32_t remote_ssrc = vie_receiver_.GetRemoteSsrc();
- std::vector<RTCPReportBlock>::const_iterator it = report_blocks.begin();
- for (; it != report_blocks.end(); ++it) {
- if (it->remoteSSRC == remote_ssrc)
- break;
- }
- if (it == report_blocks.end()) {
- // We have not received packets with an SSRC matching the report blocks. To
- // have a chance of calculating an RTT we will try with the SSRC of the
- // first report block received.
- // This is very important for send-only channels where we don't know the
- // SSRC of the other end.
- remote_ssrc = report_blocks[0].remoteSSRC;
- }
-
- // TODO(asapersson): Change report_block_stats to not rely on
- // GetSendRtcpStatistics to be called.
- RTCPReportBlock report =
- report_block_stats_sender_->AggregateAndStore(report_blocks);
- *fraction_lost = report.fractionLost;
- *cumulative_lost = report.cumulativeLost;
- *extended_max = report.extendedHighSeqNum;
- *jitter_samples = report.jitter;
-
- int64_t dummy;
- int64_t rtt = 0;
- if (rtp_rtcp_modules_[0]->RTT(remote_ssrc, &rtt, &dummy, &dummy, &dummy) !=
- 0) {
- return -1;
- }
- *rtt_ms = rtt;
- return 0;
-}
-
void ViEChannel::RegisterSendChannelRtcpStatisticsCallback(
RtcpStatisticsCallback* callback) {
for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_)
« webrtc/video/vie_channel.h ('K') | « webrtc/video/vie_channel.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698