Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 1669623004: Use CallStats for RTT in Call, rather than VideoSendStream::GetRtt() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comment, rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/call_stats_unittest.cc ('k') | webrtc/video/send_statistics_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 6de9e483d861bb0bd351d7f7fa108730d76d3c2d..20e2919a1f1b4a5c714b0bdbe02d82d2c7c051cc 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -2106,12 +2106,6 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
if (MinMetricRunTimePassed())
observation_complete_.Set();
- // GetStats calls GetSendChannelRtcpStatistics
- // (via VideoSendStream::GetRtt) which updates ReportBlockStats used by
- // WebRTC.Video.SentPacketsLostInPercent.
- // TODO(asapersson): Remove dependency on calling GetStats.
- sender_call_->GetStats();
-
return SEND_PACKET;
}
@@ -2212,8 +2206,8 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
EXPECT_EQ(1, test::NumHistogramSamples(
"WebRTC.Video.KeyFramesReceivedInPermille"));
- EXPECT_EQ(1, test::NumHistogramSamples(
- "WebRTC.Video.SentPacketsLostInPercent"));
+ EXPECT_EQ(
+ 1, test::NumHistogramSamples(video_prefix + "SentPacketsLostInPercent"));
EXPECT_EQ(1, test::NumHistogramSamples(
"WebRTC.Video.ReceivedPacketsLostInPercent"));
« no previous file with comments | « webrtc/video/call_stats_unittest.cc ('k') | webrtc/video/send_statistics_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698