Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: webrtc/video/vie_channel.h

Issue 1669623004: Use CallStats for RTT in Call, rather than VideoSendStream::GetRtt() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/vie_channel.h
diff --git a/webrtc/video/vie_channel.h b/webrtc/video/vie_channel.h
index 3c00749e72e6b6d2a075da57874b4551a53a9ac4..01f63427174118302e025ef81b4fd4cb50ad64f5 100644
--- a/webrtc/video/vie_channel.h
+++ b/webrtc/video/vie_channel.h
@@ -41,7 +41,6 @@ class PacketRouter;
class PayloadRouter;
class ProcessThread;
class ReceiveStatisticsProxy;
-class ReportBlockStats;
class RtcpRttStats;
class ViEChannelProtectionCallback;
class ViERTPObserver;
@@ -139,14 +138,6 @@ class ViEChannel : public VCMFrameTypeCallback,
// Gets the CName of the incoming stream.
int32_t GetRemoteRTCPCName(char rtcp_cname[]);
- // Returns statistics reported by the remote client in an RTCP packet.
- // TODO(pbos): Remove this along with VideoSendStream::GetRtt().
- int32_t GetSendRtcpStatistics(uint16_t* fraction_lost,
- uint32_t* cumulative_lost,
- uint32_t* extended_max,
- uint32_t* jitter_samples,
- int64_t* rtt_ms);
-
// Called on receipt of RTCP report block from remote side.
void RegisterSendChannelRtcpStatisticsCallback(
RtcpStatisticsCallback* callback);
@@ -430,12 +421,7 @@ class ViEChannel : public VCMFrameTypeCallback,
int max_nack_reordering_threshold_;
I420FrameCallback* pre_render_callback_ GUARDED_BY(crit_);
- const rtc::scoped_ptr<ReportBlockStats> report_block_stats_sender_;
-
- int64_t time_of_first_rtt_ms_ GUARDED_BY(crit_);
- int64_t rtt_sum_ms_ GUARDED_BY(crit_);
int64_t last_rtt_ms_ GUARDED_BY(crit_);
- size_t num_rtts_ GUARDED_BY(crit_);
// RtpRtcp modules, declared last as they use other members on construction.
const std::vector<RtpRtcp*> rtp_rtcp_modules_;

Powered by Google App Engine
This is Rietveld 408576698