Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: webrtc/video/call_stats.h

Issue 1669623004: Use CallStats for RTT in Call, rather than VideoSendStream::GetRtt() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comment, rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc ('k') | webrtc/video/call_stats.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 const int64_t rtt; 51 const int64_t rtt;
52 const int64_t time; 52 const int64_t time;
53 }; 53 };
54 54
55 protected: 55 protected:
56 void OnRttUpdate(int64_t rtt); 56 void OnRttUpdate(int64_t rtt);
57 57
58 int64_t avg_rtt_ms() const; 58 int64_t avg_rtt_ms() const;
59 59
60 private: 60 private:
61 void UpdateHistograms();
62
61 Clock* const clock_; 63 Clock* const clock_;
62 // Protecting all members. 64 // Protecting all members.
63 rtc::CriticalSection crit_; 65 rtc::CriticalSection crit_;
64 // Observer receiving statistics updates. 66 // Observer receiving statistics updates.
65 rtc::scoped_ptr<RtcpRttStats> rtcp_rtt_stats_; 67 rtc::scoped_ptr<RtcpRttStats> rtcp_rtt_stats_;
66 // The last time 'Process' resulted in statistic update. 68 // The last time 'Process' resulted in statistic update.
67 int64_t last_process_time_; 69 int64_t last_process_time_;
68 // The last RTT in the statistics update (zero if there is no valid estimate). 70 // The last RTT in the statistics update (zero if there is no valid estimate).
69 int64_t max_rtt_ms_; 71 int64_t max_rtt_ms_;
70 int64_t avg_rtt_ms_; 72 int64_t avg_rtt_ms_;
73 int64_t sum_avg_rtt_ms_ GUARDED_BY(crit_);
74 int64_t num_avg_rtt_ GUARDED_BY(crit_);
75 int64_t time_of_first_rtt_ms_ GUARDED_BY(crit_);
71 76
72 // All Rtt reports within valid time interval, oldest first. 77 // All Rtt reports within valid time interval, oldest first.
73 std::list<RttTime> reports_; 78 std::list<RttTime> reports_;
74 79
75 // Observers getting stats reports. 80 // Observers getting stats reports.
76 std::list<CallStatsObserver*> observers_; 81 std::list<CallStatsObserver*> observers_;
77 82
78 RTC_DISALLOW_COPY_AND_ASSIGN(CallStats); 83 RTC_DISALLOW_COPY_AND_ASSIGN(CallStats);
79 }; 84 };
80 85
81 } // namespace webrtc 86 } // namespace webrtc
82 87
83 #endif // WEBRTC_VIDEO_CALL_STATS_H_ 88 #endif // WEBRTC_VIDEO_CALL_STATS_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc ('k') | webrtc/video/call_stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698