Do not notify networkconnect if the connection type is unknown.

Do not notify networkconnect if the connection type is known.
This sometimes happened with sim card has a voice plan but does not have data plan.
Renable the DCHECK.

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/14d024d88261933153afd5eedeaf459ac31cb80a
Cr-Commit-Position: refs/heads/master@{#11479}

[honghaiz3, 2016-02-03 19:48:39]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-02-03 19:49:29]

Description was changed from

==========
Do not notify networkconnect if the connection type is known.
This sometimes happened with sim card has a voice plan but does not have data
plan.

BUG=
==========

to

==========
Do not notify networkconnect if the connection type is known.
This sometimes happened with sim card has a voice plan but does not have data
plan.
Renable the DCHECK.

BUG=
==========

[honghaiz3, 2016-02-03 19:51:01]

honghaiz@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[AlexG, 2016-02-03 19:55:06]

lgtm

https://codereview.webrtc.org/1668673003/diff/20001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java
(right):

https://codereview.webrtc.org/1668673003/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java:139: if
(networkInformation.type != ConnectionType.CONNECTION_UNKNOWN) {
nit: may be move duplicated code to a separate function?

private onNetworkInfoChanged(NetworkInformation networkInformation) {
  if (networkInformation.type != ConnectionType.CONNECTION_UNKNOWN) {
    observer.onNetworkConnect(networkInformation);
  }
}

[honghaiz3, 2016-02-03 20:20:44]

Patchset #2 (id:40001) has been deleted

[honghaiz3, 2016-02-03 20:21:41]

Thanks!

https://codereview.webrtc.org/1668673003/diff/20001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java
(right):

https://codereview.webrtc.org/1668673003/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java:139: if
(networkInformation.type != ConnectionType.CONNECTION_UNKNOWN) {
On 2016/02/03 19:55:06, AlexG wrote:
> nit: may be move duplicated code to a separate function?
> 
> private onNetworkInfoChanged(NetworkInformation networkInformation) {
>   if (networkInformation.type != ConnectionType.CONNECTION_UNKNOWN) {
>     observer.onNetworkConnect(networkInformation);
>   }
> }

Done. Also moved the call to networkToInfo to the same function.

[honghaiz3, 2016-02-03 22:23:29]

Patchset #3 (id:80001) has been deleted

[pthatcher1, 2016-02-03 22:41:17]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-02-03 22:41:18]

lgtm

Land if it's urgent, but please follow up with a unit test.

[honghaiz3, 2016-02-03 23:12:38]

Description was changed from

==========
Do not notify networkconnect if the connection type is known.
This sometimes happened with sim card has a voice plan but does not have data
plan.
Renable the DCHECK.

BUG=
==========

to

==========
Do not notify networkconnect if the connection type is known.
This sometimes happened with sim card has a voice plan but does not have data
plan.
Renable the DCHECK.

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/14d024d88261933153afd5eed...
==========

[commit-bot: I haz the power, 2016-02-03 23:12:39]

Description was changed from

==========
Do not notify networkconnect if the connection type is known.
This sometimes happened with sim card has a voice plan but does not have data
plan.
Renable the DCHECK.

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/14d024d88261933153afd5eed...
==========

to

==========
Do not notify networkconnect if the connection type is known.
This sometimes happened with sim card has a voice plan but does not have data
plan.
Renable the DCHECK.

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/14d024d88261933153afd5eedeaf459ac31cb80a
Cr-Commit-Position: refs/heads/master@{#11479}
==========

[honghaiz3, 2016-02-03 23:12:39]

Committed patchset #3 (id:100001) manually as
14d024d88261933153afd5eedeaf459ac31cb80a (presubmit successful).

[commit-bot: I haz the power, 2016-02-03 23:12:40]

Patchset 3 (id:??) landed as
https://crrev.com/14d024d88261933153afd5eedeaf459ac31cb80a
Cr-Commit-Position: refs/heads/master@{#11479}