Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1668673003: Do not notify networkconnect if the connection type is unknown. (Closed)

Created:
4 years, 10 months ago by honghaiz3
Modified:
4 years, 10 months ago
Reviewers:
AlexG, pthatcher1
CC:
webrtc-reviews_webrtc.org, pthatcher1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not notify networkconnect if the connection type is known. This sometimes happened with sim card has a voice plan but does not have data plan. Renable the DCHECK. BUG= R=glaznev@webrtc.org, pthatcher@webrtc.org Committed: https://crrev.com/14d024d88261933153afd5eedeaf459ac31cb80a Cr-Commit-Position: refs/heads/master@{#11479}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : merge and also check connection type is not NONE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java View 1 2 2 chunks +15 lines, -9 lines 0 comments Download
M talk/app/webrtc/java/jni/androidnetworkmonitor_jni.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
honghaiz3
4 years, 10 months ago (2016-02-03 19:51:02 UTC) #4
AlexG
lgtm https://codereview.webrtc.org/1668673003/diff/20001/talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java File talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java (right): https://codereview.webrtc.org/1668673003/diff/20001/talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java#newcode139 talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java:139: if (networkInformation.type != ConnectionType.CONNECTION_UNKNOWN) { nit: may be ...
4 years, 10 months ago (2016-02-03 19:55:06 UTC) #5
honghaiz3
Thanks! https://codereview.webrtc.org/1668673003/diff/20001/talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java File talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java (right): https://codereview.webrtc.org/1668673003/diff/20001/talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java#newcode139 talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java:139: if (networkInformation.type != ConnectionType.CONNECTION_UNKNOWN) { On 2016/02/03 19:55:06, ...
4 years, 10 months ago (2016-02-03 20:21:41 UTC) #7
pthatcher1
lgtm Land if it's urgent, but please follow up with a unit test.
4 years, 10 months ago (2016-02-03 22:41:18 UTC) #10
honghaiz3
Committed patchset #3 (id:100001) manually as 14d024d88261933153afd5eedeaf459ac31cb80a (presubmit successful).
4 years, 10 months ago (2016-02-03 23:12:39 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 23:12:40 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14d024d88261933153afd5eedeaf459ac31cb80a
Cr-Commit-Position: refs/heads/master@{#11479}

Powered by Google App Engine
This is Rietveld 408576698