talk/media/webrtc/webrtcvideoengine2_unittest.cc - Issue 1668493002: Replace uses of cricket::VideoRenderer by rtc::VideoSinkInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1668493002: Replace uses of cricket::VideoRenderer by rtc::VideoSinkInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/media/webrtc/webrtcvideoengine2_unittest.cc

diff --git a/talk/media/webrtc/webrtcvideoengine2_unittest.cc b/talk/media/webrtc/webrtcvideoengine2_unittest.cc

index d184a9f8e1fcd0e9e64e138760f677713321c66b..901a6c166273139579f83a5f8a18d4c49ab3a5bc 100644

--- a/talk/media/webrtc/webrtcvideoengine2_unittest.cc

+++ b/talk/media/webrtc/webrtcvideoengine2_unittest.cc

@@ -810,7 +810,7 @@ WEBRTC_BASE_TEST(SetSendBandwidth);

WEBRTC_BASE_TEST(SetSendSsrc);

WEBRTC_BASE_TEST(SetSendSsrcAfterSetCodecs);

-WEBRTC_BASE_TEST(SetRenderer);

+WEBRTC_BASE_TEST(SetSink);

WEBRTC_BASE_TEST(AddRemoveSendStreams);

@@ -1818,7 +1818,7 @@ TEST_F(WebRtcVideoChannel2Test, EstimatesNtpStartTimeCorrectly) {

FakeVideoReceiveStream* stream = AddRecvStream();

cricket::FakeVideoRenderer renderer;

- EXPECT_TRUE(channel_->SetRenderer(last_ssrc_, &renderer));

+ EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));

webrtc::VideoFrame video_frame;

CreateBlackFrame(&video_frame, 4, 4);

« no previous file with comments | « talk/media/webrtc/webrtcvideoengine2.cc ('k') | talk/session/media/channel.h » ('j') | no next file with comments »