Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1668493002: Replace uses of cricket::VideoRenderer by rtc::VideoSinkInterface. (Closed)

Created:
4 years, 10 months ago by nisse-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace uses of cricket::VideoRenderer by rtc::VideoSinkInterface. Change argument type for VideoProviderInterface::SetVideoPlayout. Replace VideoMediaChannel::SetRenderer and VideoChannel::SetRenderer by SetSink. Alse deleted unused member variables VideoMediaChannel::renderer_ and VideoChannel::renderer_. BUG=webrtc:5426 Committed: https://crrev.com/08582ff0754d906787ec93769a7ae9a8196ea7d8 Cr-Commit-Position: refs/heads/master@{#11485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -85 lines) Patch
M talk/app/webrtc/mediastreamprovider.h View 2 chunks +6 lines, -3 lines 0 comments Download
M talk/app/webrtc/rtpsenderreceiver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/webrtcsession.h View 1 chunk +4 lines, -3 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 4 chunks +10 lines, -8 lines 0 comments Download
M talk/media/base/mediachannel.h View 4 chunks +6 lines, -7 lines 0 comments Download
M talk/media/base/videoengine_unittest.h View 21 chunks +28 lines, -28 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.h View 2 chunks +6 lines, -4 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 4 chunks +14 lines, -13 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M talk/session/media/channel.h View 3 chunks +2 lines, -2 lines 0 comments Download
M talk/session/media/channel.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nisse-webrtc
This is a significant step towards deleting cricket::VideoRenderer.
4 years, 10 months ago (2016-02-03 10:16:20 UTC) #2
pthatcher1
lgtm Wow, you read my mind. I was just suggesting this, and you already have ...
4 years, 10 months ago (2016-02-03 16:27:08 UTC) #3
perkj_webrtc
lgtm
4 years, 10 months ago (2016-02-04 07:26:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668493002/1
4 years, 10 months ago (2016-02-04 08:25:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 09:24:56 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 09:25:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08582ff0754d906787ec93769a7ae9a8196ea7d8
Cr-Commit-Position: refs/heads/master@{#11485}

Powered by Google App Engine
This is Rietveld 408576698