Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1668473003: Delete backwards compatibility cruft from cricket::VideoFrame and VideoSourceInterface. (Closed)

Created:
4 years, 10 months ago by nisse-webrtc
Modified:
4 years, 10 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete backwards compatibility cruft from cricket::VideoFrame and VideoSourceInterface. Follow up to cls https://codereview.webrtc.org/1594973006/ and https://codereview.webrtc.org/1586613002/, possible now that the chrome cls https://codereview.chromium.org/1660483002/ and https://codereview.chromium.org/1603463007/ are landed. BUG=webrtc:5426 Committed: https://crrev.com/8cb910d2fd5fb42b906db02de68d800fb4bc846d Cr-Commit-Position: refs/heads/master@{#11484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -34 lines) Patch
M talk/app/webrtc/videosourceinterface.h View 1 chunk +3 lines, -19 lines 0 comments Download
M talk/app/webrtc/videotrack_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/base/videoframe.h View 1 chunk +0 lines, -5 lines 0 comments Download
M talk/media/webrtc/webrtcvideoframe.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nisse-webrtc
4 years, 10 months ago (2016-02-03 11:06:24 UTC) #2
perkj_webrtc
lgtm
4 years, 10 months ago (2016-02-03 16:02:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668473003/1
4 years, 10 months ago (2016-02-03 16:02:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_rel/builds/836) win_compile_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 10 months ago (2016-02-03 16:03:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668473003/1
4 years, 10 months ago (2016-02-04 08:26:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 09:01:57 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 09:02:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cb910d2fd5fb42b906db02de68d800fb4bc846d
Cr-Commit-Position: refs/heads/master@{#11484}

Powered by Google App Engine
This is Rietveld 408576698