Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1667503002: Fixing a DCHECK failure on unknown connection type from OS. (Closed)

Created:
4 years, 10 months ago by honghaiz3
Modified:
4 years, 10 months ago
Reviewers:
AlexG, pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing a DCHECK failure on unknown connection type from OS. Sometimes Android OS provides unknown connection type, causing a DCHECK failure. This CL temporarily removes that checking. BUG= TBR=glaznev@webrtc.org NOTRY=true Committed: https://crrev.com/27a348555a5de5c5fd79cabe500a972f8ca7e3d1 Cr-Commit-Position: refs/heads/master@{#11466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M talk/app/webrtc/java/jni/androidnetworkmonitor_jni.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
honghaiz3
4 years, 10 months ago (2016-02-03 01:46:26 UTC) #3
AlexG
lgtm
4 years, 10 months ago (2016-02-03 02:04:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667503002/1
4 years, 10 months ago (2016-02-03 02:15:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 02:20:31 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 02:20:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27a348555a5de5c5fd79cabe500a972f8ca7e3d1
Cr-Commit-Position: refs/heads/master@{#11466}

Powered by Google App Engine
This is Rietveld 408576698