webrtc/base/thread.h - Issue 1666863002: Fix race between Thread ctor/dtor and MessageQueueManager registrations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/thread.h

Issue 1666863002: Fix race between Thread ctor/dtor and MessageQueueManager registrations. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added comment to MessageQueue constructor. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/thread.h

diff --git a/webrtc/base/thread.h b/webrtc/base/thread.h

index f91aa56733cb82a880adf6c35ae43114c712fe07..f03bf3839275948876f4867d12622eabe18a1a2c 100644

--- a/webrtc/base/thread.h

+++ b/webrtc/base/thread.h

@@ -297,7 +297,7 @@ class AutoThread : public Thread {

class ComThread : public Thread {

public:

ComThread() {}

- virtual ~ComThread() { Stop(); }

+ ~ComThread() override;

protected:

virtual void Run();

« webrtc/base/messagequeue.h ('K') | « webrtc/base/messagequeue.cc ('k') | webrtc/base/thread.cc » ('j') | no next file with comments »