Fix race between Thread ctor/dtor and MessageQueueManager registrations.

webrtc/base/thread.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 121 matching lines @@
   : thread_(Thread::Current()),
     previous_state_(thread_->SetAllowBlockingCalls(false)) {
 }
 
 Thread::ScopedDisallowBlockingCalls::~ScopedDisallowBlockingCalls() {
   ASSERT(thread_->IsCurrent());
   thread_->SetAllowBlockingCalls(previous_state_);
 }
 
 Thread::Thread(SocketServer* ss)
-    : MessageQueue(ss),
+    : MessageQueue(ss, false),
       running_(true, false),
 #if defined(WEBRTC_WIN)
       thread_(NULL),
       thread_id_(0),
 #endif
       owned_(true),
       blocking_calls_allowed_(true) {
   SetName("Thread", this);  // default name
+  MessageQueueManager::Add(this);
 }
 
 Thread::~Thread() {
   Stop();
-  Clear(NULL);
+  DoDestroy();
 }
 
 bool Thread::SleepMs(int milliseconds) {
   AssertBlockingIsAllowedOnCurrentThread();
 
 #if defined(WEBRTC_WIN)
   ::Sleep(milliseconds);
   return true;
 #else
   // POSIX has both a usleep() and a nanosleep(), but the former is deprecated,
@@ skipping 346 matching lines @@
 }
 
 AutoThread::AutoThread(SocketServer* ss) : Thread(ss) {
   if (!ThreadManager::Instance()->CurrentThread()) {
     ThreadManager::Instance()->SetCurrentThread(this);
   }
 }
 
 AutoThread::~AutoThread() {
   Stop();
+  DoDestroy();
   if (ThreadManager::Instance()->CurrentThread() == this) {
     ThreadManager::Instance()->SetCurrentThread(NULL);
   }
 }
 
 #if defined(WEBRTC_WIN)
+ComThread::~ComThread() {
+  Stop();
+  DoDestroy();
+}
+
 void ComThread::Run() {
   HRESULT hr = CoInitializeEx(NULL, COINIT_MULTITHREADED);
   ASSERT(SUCCEEDED(hr));
   if (SUCCEEDED(hr)) {
     Thread::Run();
     CoUninitialize();
   } else {
     LOG(LS_ERROR) << "CoInitialize failed, hr=" << hr;
   }
 }
 #endif
 
 }  // namespace rtc