Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1666843003: Bugfix to stop chrome from crashing. (Closed)

Created:
4 years, 10 months ago by ivoc
Modified:
4 years, 10 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds a nullptr check to prevent a rare crash when starting or stopping an RtcEventLog. BUG=webrtc:4741, chromium:581788 Committed: https://crrev.com/20834ca806595a4f46c838f1e69c32d0c836fb12 Cr-Commit-Position: refs/heads/master@{#11490}

Patch Set 1 #

Patch Set 2 : Added namespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M talk/media/webrtc/webrtcvoiceengine.cc View 1 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
ivoc
Hi Fredrik, This is exactly the same bugfix as the one you reviewed earlier, but ...
4 years, 10 months ago (2016-02-04 12:50:48 UTC) #3
the sun
lgtm
4 years, 10 months ago (2016-02-04 12:51:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666843003/1
4 years, 10 months ago (2016-02-04 12:58:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_compile_dbg/builds/2811)
4 years, 10 months ago (2016-02-04 13:00:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666843003/20001
4 years, 10 months ago (2016-02-04 13:32:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-04 14:33:41 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 14:33:45 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20834ca806595a4f46c838f1e69c32d0c836fb12
Cr-Commit-Position: refs/heads/master@{#11490}

Powered by Google App Engine
This is Rietveld 408576698