Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1666163002: Revert of Rename iOS test specs to match buildbot names. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Rename iOS test specs to match buildbot names. (patchset #1 id:1 of https://codereview.webrtc.org/1665783002/ ) Reason for revert: *sigh* that didn't work, the reading of the JSON file fails (which I was suspecting it would). Example: https://build.chromium.org/p/client.webrtc.fyi/builders/iOS64%20Simulator%20Debug/builds/17/steps/steps/logs/stdio I'll rename all the iOS bots instead since I think it's reasonably rare we link to their logs, so there won't be that many broken URLs. Original issue's description: > Rename iOS test specs to match buildbot names. > > I really prefer not using spaces in any filenames but > if we were to rename all the bots all existing URLs to builds > would stop working (or we'd loose the build history), so I'd > like to see if this works first. > The bots that hits the errors are the new ones I'm experimenting > with in client.webrtc.fyi. Example failing build: > https://build.chromium.org/p/client.webrtc.fyi/builders/iOS64%20Simulator%20Debug > > BUG=chromium:498746 > NOTRY=True > TBR=phoglund@webrtc.org > > Committed: https://crrev.com/86512b401ecee4b5e18ee6fbec28ec9c1d0ead9b > Cr-Commit-Position: refs/heads/master@{#11473} TBR=phoglund@webrtc.org NOTRY=True NOPRESUBMIT=True BUG=chromium:498746 Committed: https://crrev.com/15ba6242ad327e25b5b11a09d9175200b93f205a Cr-Commit-Position: refs/heads/master@{#11489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -182 lines) Patch
D webrtc/build/ios/client.webrtc.fyi/iOS32 Debug.json View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS32 Release.json View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS32 Simulator Debug.json View 1 chunk +0 lines, -25 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS32_Debug.json View 1 chunk +20 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS32_Release.json View 1 chunk +20 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS32_Simulator_Debug.json View 1 chunk +25 lines, -0 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64 Debug.json View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64 Debug (GN).json View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64 Release.json View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64 Release (GN).json View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64 Simulator Debug.json View 1 chunk +0 lines, -25 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Debug.json View 1 chunk +20 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Debug_(GN).json View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Release.json View 1 chunk +20 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Release_(GN).json View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Simulator_Debug.json View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
kjellander_webrtc
Created Revert of Rename iOS test specs to match buildbot names.
4 years, 10 months ago (2016-02-04 13:11:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666163002/1
4 years, 10 months ago (2016-02-04 13:11:31 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/4941) ios64_sim_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 10 months ago (2016-02-04 13:12:43 UTC) #4
kjellander_webrtc
On 2016/02/04 13:12:43, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-04 13:58:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666163002/1
4 years, 10 months ago (2016-02-04 13:59:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3242)
4 years, 10 months ago (2016-02-04 14:04:39 UTC) #10
kjellander_webrtc
On 2016/02/04 14:04:39, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-04 14:09:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666163002/1
4 years, 10 months ago (2016-02-04 14:09:54 UTC) #14
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-04 14:10:09 UTC) #16
kjellander_webrtc
Committed patchset #1 (id:1) manually as 15ba6242ad327e25b5b11a09d9175200b93f205a (presubmit successful).
4 years, 10 months ago (2016-02-04 14:13:58 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 14:14:01 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15ba6242ad327e25b5b11a09d9175200b93f205a
Cr-Commit-Position: refs/heads/master@{#11489}

Powered by Google App Engine
This is Rietveld 408576698