Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1665803003: Remove dead code from WebRtcVideoEngine2. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dead code from WebRtcVideoEngine2. FindCodec is no longer used and can be removed. BUG= R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/cedff02e3040524e917a68439f1598538f585638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -82 lines) Patch
M talk/media/base/fakemediaengine.h View 1 chunk +0 lines, -8 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.h View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-03 16:11:07 UTC) #1
pthatcher1
lgtm
4 years, 10 months ago (2016-02-03 16:25:20 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as cedff02e3040524e917a68439f1598538f585638 (presubmit successful).
4 years, 10 months ago (2016-02-03 16:59:02 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 16:59:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cedff02e3040524e917a68439f1598538f585638
Cr-Commit-Position: refs/heads/master@{#11476}

Powered by Google App Engine
This is Rietveld 408576698