Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1665783002: Rename iOS test specs to match buildbot names. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename iOS test specs to match buildbot names. I really prefer not using spaces in any filenames but if we were to rename all the bots all existing URLs to builds would stop working (or we'd loose the build history), so I'd like to see if this works first. The bots that hits the errors are the new ones I'm experimenting with in client.webrtc.fyi. Example failing build: https://build.chromium.org/p/client.webrtc.fyi/builders/iOS64%20Simulator%20Debug BUG=chromium:498746 NOTRY=True TBR=phoglund@webrtc.org Committed: https://crrev.com/86512b401ecee4b5e18ee6fbec28ec9c1d0ead9b Cr-Commit-Position: refs/heads/master@{#11473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-8 lines, -174 lines) Patch
A + webrtc/build/ios/client.webrtc.fyi/iOS32 Debug.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/build/ios/client.webrtc.fyi/iOS32 Release.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/build/ios/client.webrtc.fyi/iOS32 Simulator Debug.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS32_Debug.json View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS32_Release.json View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS32_Simulator_Debug.json View 1 chunk +0 lines, -25 lines 0 comments Download
A + webrtc/build/ios/client.webrtc.fyi/iOS64 Debug.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/build/ios/client.webrtc.fyi/iOS64 Debug (GN).json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/build/ios/client.webrtc.fyi/iOS64 Release.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/build/ios/client.webrtc.fyi/iOS64 Release (GN).json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/build/ios/client.webrtc.fyi/iOS64 Simulator Debug.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64_Debug.json View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64_Debug_(GN).json View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64_Release.json View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64_Release_(GN).json View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64_Simulator_Debug.json View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kjellander_webrtc
4 years, 10 months ago (2016-02-03 12:37:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665783002/1
4 years, 10 months ago (2016-02-03 12:37:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 12:41:08 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86512b401ecee4b5e18ee6fbec28ec9c1d0ead9b Cr-Commit-Position: refs/heads/master@{#11473}
4 years, 10 months ago (2016-02-03 12:41:17 UTC) #9
phoglund
lgtm
4 years, 10 months ago (2016-02-03 12:47:39 UTC) #10
kjellander_webrtc
4 years, 10 months ago (2016-02-04 13:11:17 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1666163002/ by kjellander@webrtc.org.

The reason for reverting is: *sigh* that didn't work, the reading of the JSON
file fails (which I was suspecting it would).
Example:
https://build.chromium.org/p/client.webrtc.fyi/builders/iOS64%20Simulator%20D...


I'll rename all the iOS bots instead since I think it's reasonably rare we link
to their logs, so there won't be that many broken URLs..

Powered by Google App Engine
This is Rietveld 408576698