Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1665603003: Move gtest_prod_util.h out of webrtc/test tree. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move gtest_prod_util.h out of webrtc/test tree. This is needed because the target is defined in webrtc/common.gyp and its current location crosses package boundaries when generating projects for some build systems. NOTRY=True Committed: https://crrev.com/988d31eb9bf60d1cbe563d64f88f7e0132ca143a Cr-Commit-Position: refs/heads/master@{#11496}

Patch Set 1 #

Patch Set 2 : Updated include paths #

Patch Set 3 : Moved to webrtc/base instead #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -66 lines) Patch
M webrtc/BUILD.gn View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
A + webrtc/base/gtest_prod_util.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common.gyp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/common_audio/channel_buffer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/nack.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/transient/transient_suppressor.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/test.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
D webrtc/test/testsupport/gtest_prod_util.h View 1 chunk +0 lines, -38 lines 0 comments Download
M webrtc/tools/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/internal_tools.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/simple_command_line_parser.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
kjellander_webrtc
4 years, 10 months ago (2016-02-03 15:22:25 UTC) #2
phoglund
We should be restrictive with putting headers in webrtc/, but I can live with that ...
4 years, 10 months ago (2016-02-03 15:45:21 UTC) #3
kjellander_webrtc
On 2016/02/03 15:45:21, phoglund wrote: > We should be restrictive with putting headers in webrtc/, ...
4 years, 10 months ago (2016-02-03 15:49:42 UTC) #4
kjellander_webrtc
looks like it's working now. +tommi for root owner approval.
4 years, 10 months ago (2016-02-03 16:25:13 UTC) #5
kjellander_webrtc
+tommi
4 years, 10 months ago (2016-02-03 16:25:29 UTC) #7
kjellander_webrtc
+henrika for other root owner since tommi seems busy.
4 years, 10 months ago (2016-02-05 07:46:03 UTC) #9
tommi
lgtm
4 years, 10 months ago (2016-02-05 08:15:34 UTC) #10
henrika_webrtc
Looks like you are OK to land ;-)
4 years, 10 months ago (2016-02-05 08:16:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665603003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665603003/60001
4 years, 10 months ago (2016-02-05 08:19:21 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-05 08:23:54 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 08:24:05 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/988d31eb9bf60d1cbe563d64f88f7e0132ca143a
Cr-Commit-Position: refs/heads/master@{#11496}

Powered by Google App Engine
This is Rietveld 408576698