Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1664733002: Add SEI to the list of packets counted as keyframe. (Closed)

Created:
4 years, 10 months ago by noahric
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add SEI to the list of packets counted as keyframe. It's generated by some encoders between SPS/PPS and an IDR frame, so we should treat it like sps/pps. BUG= Committed: https://crrev.com/d983c3c9e58fa957aaf6ef93b1a676a6338efae0 Cr-Commit-Position: refs/heads/master@{#11470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
noahric
There should be a bos@webrtc.org that includes both of you. Also, let me know if ...
4 years, 10 months ago (2016-02-03 09:34:13 UTC) #2
pbos-webrtc
I'll just trust you on this one, have some rubber. lgtm. Also, adding stefan@ because ...
4 years, 10 months ago (2016-02-03 09:56:13 UTC) #4
stefan-webrtc
lgtm
4 years, 10 months ago (2016-02-03 10:00:17 UTC) #5
noahric
On 2016/02/03 09:56:13, pbos-webrtc wrote: > I'll just trust you on this one, have some ...
4 years, 10 months ago (2016-02-03 10:00:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664733002/1
4 years, 10 months ago (2016-02-03 10:01:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 11:43:46 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 11:43:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d983c3c9e58fa957aaf6ef93b1a676a6338efae0
Cr-Commit-Position: refs/heads/master@{#11470}

Powered by Google App Engine
This is Rietveld 408576698