Clean up of CongestionController.

webrtc/video/video_receive_stream.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 15 matching lines @@
 #include "webrtc/video/vie_channel.h"
 #include "webrtc/video/vie_encoder.h"
 #include "webrtc/video_encoder.h"
 #include "webrtc/video_receive_stream.h"
 
 namespace webrtc {
 
 class CallStats;
 class CongestionController;
 class VoiceEngine;
+class VieRemb;
 
 namespace internal {
 
 class VideoReceiveStream : public webrtc::VideoReceiveStream,
                            public I420FrameCallback,
                            public VideoRenderCallback,
                            public EncodedImageCallback {
  public:
   VideoReceiveStream(int num_cpu_cores,
                      CongestionController* congestion_controller,
                      const VideoReceiveStream::Config& config,
                      webrtc::VoiceEngine* voice_engine,
                      ProcessThread* process_thread,
-                     CallStats* call_stats);
+                     CallStats* call_stats,
+                     VieRemb* remb);

[the sun, 2016/02/08 10:39:23]

For the audio streams, I've created a shared AudioState object, which is passed
down. I think it could make sense to do something similar for video. Then we
could avoid passing naked pointers like this, instead pass the state as a ref
counted object and get the various fields with accessors.

See:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...
and
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

I'm not suggesting you do it in this CL, but maybe think about it?

[stefan-webrtc, 2016/02/08 13:30:54]

Possibly. pbos, what's your opinion on this?

   ~VideoReceiveStream() override;
 
   // webrtc::ReceiveStream implementation.
   void Start() override;
   void Stop() override;
   void SignalNetworkState(NetworkState state) override;
   bool DeliverRtcp(const uint8_t* packet, size_t length) override;
   bool DeliverRtp(const uint8_t* packet,
                   size_t length,
                   const PacketTime& packet_time) override;
@@ skipping 19 matching lines @@
 
  private:
   TransportAdapter transport_adapter_;
   EncodedFrameCallbackAdapter encoded_frame_proxy_;
   const VideoReceiveStream::Config config_;
   ProcessThread* const process_thread_;
   Clock* const clock_;
 
   CongestionController* const congestion_controller_;
   CallStats* const call_stats_;
+  VieRemb* const remb_;
 
   rtc::scoped_ptr<VideoCodingModule> vcm_;
   IncomingVideoStream incoming_video_stream_;
   ReceiveStatisticsProxy stats_proxy_;
   ViEChannel vie_channel_;
 };
 }  // namespace internal
 }  // namespace webrtc
 
 #endif  // WEBRTC_VIDEO_VIDEO_RECEIVE_STREAM_H_