Re-enable RestartingSendStreamPreservesRtpState.

Re-enable RestartingSendStreamPreservesRtpState.

based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.

BUG=webrtc:3552
R=pbos@webrtc.org

Committed: https://crrev.com/5c35cf9f8ee659385a2a12075eb25335c71df786
Cr-Commit-Position: refs/heads/master@{#11477}

[danilchap, 2016-02-03 12:30:12]

Description was changed from

==========
Re-enable RestartingSendStreamPreservesRtpState.

based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.

BUG=webrtc:3552
R=pbos@webrtc.org
==========

to

==========
Re-enable RestartingSendStreamPreservesRtpState.

based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.

BUG=webrtc:3552
R=pbos@webrtc.org
==========

[danilchap, 2016-02-03 12:30:12]

danilchap@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2016-02-03 12:40:12]

lgtm if the linux_memcheck and win_drmemory_full trybots are passing, which I
just triggered.
They're not run by default since they're so slow.

[pbos-webrtc, 2016-02-03 13:03:27]

https://codereview.webrtc.org/1661923002/diff/1/webrtc/video/end_to_end_tests.cc
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/1661923002/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:2972: std::list<uint16_t>& seq_numbers =
last_observed_seq_numbers_[ssrc];
pointer instead of reference here please.

https://codereview.webrtc.org/1661923002/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:2982: // Verify sequence numbers are reasonably
close.
There should be some timediff function that does this abs_diff for you already.

[pbos-webrtc, 2016-02-03 13:26:56]

On 2016/02/03 13:03:27, pbos-webrtc wrote:
>
https://codereview.webrtc.org/1661923002/diff/1/webrtc/video/end_to_end_tests.cc
> File webrtc/video/end_to_end_tests.cc (right):
> 
>
https://codereview.webrtc.org/1661923002/diff/1/webrtc/video/end_to_end_tests...
> webrtc/video/end_to_end_tests.cc:2972: std::list<uint16_t>& seq_numbers =
> last_observed_seq_numbers_[ssrc];
> pointer instead of reference here please.
> 
>
https://codereview.webrtc.org/1661923002/diff/1/webrtc/video/end_to_end_tests...
> webrtc/video/end_to_end_tests.cc:2982: // Verify sequence numbers are
reasonably
> close.
> There should be some timediff function that does this abs_diff for you
already.

Maybe webrtc/modules/include/module_common_types.h can be refactored so that:

IsNewerSequenceNumber calls SequenceNumberDiff >= 0 or something, and you put
abs_diff = std::abs(SequenceNumberDiff..) there?

[danilchap, 2016-02-03 14:04:49]

https://codereview.webrtc.org/1661923002/diff/1/webrtc/video/end_to_end_tests.cc
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/1661923002/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:2972: std::list<uint16_t>& seq_numbers =
last_observed_seq_numbers_[ssrc];
On 2016/02/03 13:03:27, pbos-webrtc wrote:
> pointer instead of reference here please.

Done.

https://codereview.webrtc.org/1661923002/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:2982: // Verify sequence numbers are reasonably
close.
On 2016/02/03 13:03:27, pbos-webrtc wrote:
> There should be some timediff function that does this abs_diff for you
already.

Failed to find it. Thank you for pointing where it is.
instead of IsNewer used Unwrapper since that fits better how seq numbers are
used in this test.
The case where 1st packet starts with 2^16-1 and comes before packet with seq_no
0 is silently ignored because maximum starting seq_no is 2^15-1.

[pbos-webrtc, 2016-02-03 14:06:09]

lgtm, thanks

[kjellander_webrtc, 2016-02-03 14:36:08]

On 2016/02/03 14:06:09, pbos-webrtc wrote:
> lgtm, thanks

Please run linux_memcheck and win_drmemory_full for PS#2 to ensure it works
before committing.

[danilchap, 2016-02-03 21:30:19]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-02-03 21:30:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1661923002/#ps40001 (title:
"allowed timestamp gap to be negative too")

[commit-bot: I haz the power, 2016-02-03 21:30:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1661923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1661923002/40001

[commit-bot: I haz the power, 2016-02-03 22:14:53]

Description was changed from

==========
Re-enable RestartingSendStreamPreservesRtpState.

based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.

BUG=webrtc:3552
R=pbos@webrtc.org
==========

to

==========
Re-enable RestartingSendStreamPreservesRtpState.

based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.

BUG=webrtc:3552
R=pbos@webrtc.org
==========

[commit-bot: I haz the power, 2016-02-03 22:14:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-03 22:15:05]

Description was changed from

==========
Re-enable RestartingSendStreamPreservesRtpState.

based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.

BUG=webrtc:3552
R=pbos@webrtc.org
==========

to

==========
Re-enable RestartingSendStreamPreservesRtpState.

based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.

BUG=webrtc:3552
R=pbos@webrtc.org

Committed: https://crrev.com/5c35cf9f8ee659385a2a12075eb25335c71df786
Cr-Commit-Position: refs/heads/master@{#11477}
==========

[commit-bot: I haz the power, 2016-02-03 22:15:07]

Patchset 3 (id:??) landed as
https://crrev.com/5c35cf9f8ee659385a2a12075eb25335c71df786
Cr-Commit-Position: refs/heads/master@{#11477}