Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 1661203002: Add more logging and fix PTS overflow for HW decoder. (Closed)

Created:
4 years, 10 months ago by AlexG
Modified:
4 years, 10 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add more logging and fix PTS overflow for HW decoder. - Reduce maximum pending frames for H.264 decoder to 8. - Log data for next 2 output frames every time frame drop happens or decoder drain is triggered. - When timeout happens for dequeueInputBuffer call try to drain the decoder and get input buffer one more time. - Fix PTS values overflow. Committed: https://crrev.com/ae95ff32ff6920660aacf0978a3cb6c4be595a40 Cr-Commit-Position: refs/heads/master@{#11492}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -27 lines) Patch
M talk/app/webrtc/java/jni/androidmediacodeccommon.h View 1 chunk +3 lines, -3 lines 0 comments Download
M talk/app/webrtc/java/jni/androidmediadecoder_jni.cc View 1 10 chunks +52 lines, -22 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
AlexG
PTAL
4 years, 10 months ago (2016-02-03 23:57:56 UTC) #2
perkj_webrtc
can you please add link to bug? lgtm https://codereview.webrtc.org/1661203002/diff/1/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc File talk/app/webrtc/java/jni/androidmediadecoder_jni.cc (right): https://codereview.webrtc.org/1661203002/diff/1/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc#newcode575 talk/app/webrtc/java/jni/androidmediadecoder_jni.cc:575: if ...
4 years, 10 months ago (2016-02-04 07:22:09 UTC) #3
AlexG
https://codereview.webrtc.org/1661203002/diff/1/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc File talk/app/webrtc/java/jni/androidmediadecoder_jni.cc (right): https://codereview.webrtc.org/1661203002/diff/1/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc#newcode575 talk/app/webrtc/java/jni/androidmediadecoder_jni.cc:575: if (!DeliverPendingOutputs(jni, kMediaCodecPollMs)) { On 2016/02/04 07:22:08, perkj_webrtc wrote: ...
4 years, 10 months ago (2016-02-04 18:47:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661203002/20001
4 years, 10 months ago (2016-02-04 18:48:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-04 19:47:17 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 19:47:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae95ff32ff6920660aacf0978a3cb6c4be595a40
Cr-Commit-Position: refs/heads/master@{#11492}

Powered by Google App Engine
This is Rietveld 408576698