webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc - Issue 1660963002: Bitrate controller for VideoToolbox encoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc

Issue 1660963002: Bitrate controller for VideoToolbox encoder. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: CR comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/bitrate_adjuster.cc ('K') | « webrtc/modules/video_coding/bitrate_adjuster_unittest.cc ('k') | webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h » ('j') | webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc

index e79fdfb69841576fbb790972d9d3e211d346409d..20d8aef55e08e8b786fbd6258c5c6511490f2d72 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc

+++ b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc

@@ -164,6 +164,10 @@ int H264VideoToolboxDecoder::RegisterDecodeCompleteCallback(

}

int H264VideoToolboxDecoder::Release() {

+ // Need to invalidate the session so that callbacks no longer occur and it

+ // is safe to null out the callback.

+ DestroyDecompressionSession();

+ SetVideoFormat(nullptr);

callback_ = nullptr;

return WEBRTC_VIDEO_CODEC_OK;

}