Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: webrtc/modules/video_coding/bitrate_adjuster_unittest.cc

Issue 1660963002: Bitrate controller for VideoToolbox encoder. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix GN build. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/bitrate_adjuster_unittest.cc
diff --git a/webrtc/modules/video_coding/bitrate_adjuster_unittest.cc b/webrtc/modules/video_coding/bitrate_adjuster_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e64118db4c929b1f20e00046a6e26d94327b8356
--- /dev/null
+++ b/webrtc/modules/video_coding/bitrate_adjuster_unittest.cc
@@ -0,0 +1,111 @@
+/*
+ * Copyright 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+#include "webrtc/modules/video_coding/include/bitrate_adjuster.h"
+#include "webrtc/system_wrappers/include/clock.h"
+
+namespace webrtc {
+
+class BitrateAdjusterTest : public ::testing::Test,
+ public BitrateAdjusterObserver {
+ public:
+ BitrateAdjusterTest()
+ : clock_(0), adjuster_(&clock_, this), adjusted_bitrate_kbit_(0) {}
+
+ virtual void OnBitrateAdjusted(uint32_t adjusted_bitrate) {
+ adjusted_bitrate_kbit_ = adjusted_bitrate;
+ }
+
+ // Simulate an output bitrate for one update cycle of BitrateAdjuster.
+ void SimulateBitrate(uint32_t bitrate_in_kbit) {
+ const uint32_t update_interval_ms =
+ BitrateAdjuster::kBitrateUpdateIntervalMs;
+ const uint32_t update_frame_interval =
+ BitrateAdjuster::kBitrateUpdateFrameInterval;
+ // Round up frame interval so we get one cycle passes.
+ const uint32_t frame_interval_ms =
+ (update_interval_ms + update_frame_interval - 1) /
+ update_frame_interval;
+ const size_t frame_size_bytes = (bitrate_in_kbit * frame_interval_ms) / 8;
+ for (size_t i = 0; i < update_frame_interval; ++i) {
+ clock_.AdvanceTimeMilliseconds(frame_interval_ms);
+ adjuster_.Update(frame_size_bytes);
+ }
+ }
+
+ void VerifyAdjustment() {
+ // The adjusted bitrate should be between the estimated bitrate and the
+ // target bitrate within clamp.
+ uint32_t target_bitrate = adjuster_.GetTargetBitrate();
+ uint32_t adjusted_bitrate = adjuster_.GetAdjustedBitrate();
+ uint32_t estimated_bitrate = adjuster_.GetEstimatedBitrate();
+ uint32_t adjusted_lower_bound = adjuster_.GetMinAdjustedBitrate();
+ uint32_t adjusted_upper_bound = adjuster_.GetMaxAdjustedBitrate();
+ EXPECT_LE(adjusted_bitrate, adjusted_upper_bound);
+ EXPECT_GE(adjusted_bitrate, adjusted_lower_bound);
+ if (estimated_bitrate > target_bitrate) {
+ EXPECT_LT(adjusted_bitrate, target_bitrate);
+ }
+ }
+
+ protected:
+ SimulatedClock clock_;
+ BitrateAdjuster adjuster_;
+ uint32_t adjusted_bitrate_kbit_;
+};
+
+TEST_F(BitrateAdjusterTest, VaryingBitrates) {
+ const uint32_t target_bitrate = 640;
+ adjuster_.SetTargetBitrate(target_bitrate);
+
+ // Grossly overshoot for a little while. Adjusted bitrate should decrease.
+ uint32_t actual_bitrate = 2 * target_bitrate;
+ uint32_t last_adjusted_bitrate = 0;
+ uint32_t adjusted_bitrate = 0;
+
+ SimulateBitrate(actual_bitrate);
+ VerifyAdjustment();
+ last_adjusted_bitrate = adjuster_.GetAdjustedBitrate();
+
+ SimulateBitrate(actual_bitrate);
+ VerifyAdjustment();
+ adjusted_bitrate = adjuster_.GetAdjustedBitrate();
+ EXPECT_LT(adjusted_bitrate, last_adjusted_bitrate);
+ last_adjusted_bitrate = adjusted_bitrate;
+ // After two cycles we should've stabilized and hit the lower bound.
+ EXPECT_EQ(adjuster_.GetMinAdjustedBitrate(), adjusted_bitrate);
+
+ // Simulate encoder settling down. Adjusted bitrate should increase.
+ SimulateBitrate(target_bitrate);
+ adjusted_bitrate = adjuster_.GetAdjustedBitrate();
+ VerifyAdjustment();
+ EXPECT_GT(adjusted_bitrate, last_adjusted_bitrate);
+ last_adjusted_bitrate = adjusted_bitrate;
+
+ SimulateBitrate(target_bitrate);
+ adjusted_bitrate = adjuster_.GetAdjustedBitrate();
+ VerifyAdjustment();
+ EXPECT_GT(adjusted_bitrate, last_adjusted_bitrate);
+ last_adjusted_bitrate = adjusted_bitrate;
+ // After two cycles we should've stabilized and hit the upper bound.
+ EXPECT_EQ(adjuster_.GetMaxAdjustedBitrate(), adjusted_bitrate);
+}
+
+TEST_F(BitrateAdjusterTest, AdjustentObserver) {
+ const uint32_t target_bitrate = 640;
+ adjuster_.SetTargetBitrate(target_bitrate);
+ SimulateBitrate(1440);
+ uint32_t adjusted_bitrate_kbit = adjuster_.GetAdjustedBitrate();
+ EXPECT_EQ(adjusted_bitrate_kbit, adjusted_bitrate_kbit_);
+}
+
+} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698