Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: webrtc/modules/video_coding/bitrate_adjuster_unittest.cc

Issue 1660963002: Bitrate controller for VideoToolbox encoder. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Instant adjustments only for large rate changes. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 #include "webrtc/modules/video_coding/include/bitrate_adjuster.h"
14 #include "webrtc/system_wrappers/include/clock.h"
15
16 namespace webrtc {
17
18 class BitrateAdjusterTest : public ::testing::Test {
19 public:
20 BitrateAdjusterTest() : clock_(0), adjuster_(&clock_) {}
21
22 // Simulate an output bitrate for one update cycle of BitrateAdjuster.
23 void SimulateBitrateBps(uint32_t bitrate_bps) {
24 const uint32_t update_interval_ms =
25 BitrateAdjuster::kBitrateUpdateIntervalMs;
26 const uint32_t update_frame_interval =
27 BitrateAdjuster::kBitrateUpdateFrameInterval;
28 // Round up frame interval so we get one cycle passes.
29 const uint32_t frame_interval_ms =
30 (update_interval_ms + update_frame_interval - 1) /
31 update_frame_interval;
32 const size_t frame_size_bytes =
33 (bitrate_bps * frame_interval_ms) / (8 * 1000);
34 for (size_t i = 0; i < update_frame_interval; ++i) {
35 clock_.AdvanceTimeMilliseconds(frame_interval_ms);
36 adjuster_.Update(frame_size_bytes);
37 }
38 }
39
40 void VerifyAdjustment() {
41 // The adjusted bitrate should be between the estimated bitrate and the
42 // target bitrate within clamp.
43 uint32_t target_bitrate_bps = adjuster_.GetTargetBitrateBps();
44 uint32_t adjusted_bitrate_bps = adjuster_.GetAdjustedBitrateBps();
45 uint32_t estimated_bitrate_bps = adjuster_.GetEstimatedBitrateBps();
46 uint32_t adjusted_lower_bound_bps = adjuster_.GetMinAdjustedBitrateBps();
47 uint32_t adjusted_upper_bound_bps = adjuster_.GetMaxAdjustedBitrateBps();
48 EXPECT_LE(adjusted_bitrate_bps, adjusted_upper_bound_bps);
49 EXPECT_GE(adjusted_bitrate_bps, adjusted_lower_bound_bps);
50 if (estimated_bitrate_bps > target_bitrate_bps) {
51 EXPECT_LT(adjusted_bitrate_bps, target_bitrate_bps);
52 }
53 }
54
55 protected:
56 SimulatedClock clock_;
57 BitrateAdjuster adjuster_;
58 };
59
60 TEST_F(BitrateAdjusterTest, VaryingBitrates) {
61 const uint32_t target_bitrate_bps = 640000;
62 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
63
64 // Grossly overshoot for a little while. Adjusted bitrate should decrease.
65 uint32_t actual_bitrate_bps = 2 * target_bitrate_bps;
66 uint32_t last_adjusted_bitrate_bps = 0;
67 uint32_t adjusted_bitrate_bps = 0;
68
69 SimulateBitrateBps(actual_bitrate_bps);
70 VerifyAdjustment();
71 last_adjusted_bitrate_bps = adjuster_.GetAdjustedBitrateBps();
72
73 SimulateBitrateBps(actual_bitrate_bps);
74 VerifyAdjustment();
75 adjusted_bitrate_bps = adjuster_.GetAdjustedBitrateBps();
76 EXPECT_LT(adjusted_bitrate_bps, last_adjusted_bitrate_bps);
77 last_adjusted_bitrate_bps = adjusted_bitrate_bps;
78 // After two cycles we should've stabilized and hit the lower bound.
79 EXPECT_EQ(adjuster_.GetMinAdjustedBitrateBps(), adjusted_bitrate_bps);
80
81 // Simulate encoder settling down. Adjusted bitrate should increase.
82 SimulateBitrateBps(target_bitrate_bps);
83 adjusted_bitrate_bps = adjuster_.GetAdjustedBitrateBps();
84 VerifyAdjustment();
85 EXPECT_GT(adjusted_bitrate_bps, last_adjusted_bitrate_bps);
86 last_adjusted_bitrate_bps = adjusted_bitrate_bps;
87
88 SimulateBitrateBps(target_bitrate_bps);
89 adjusted_bitrate_bps = adjuster_.GetAdjustedBitrateBps();
90 VerifyAdjustment();
91 EXPECT_GT(adjusted_bitrate_bps, last_adjusted_bitrate_bps);
92 last_adjusted_bitrate_bps = adjusted_bitrate_bps;
93 // After two cycles we should've stabilized and hit the upper bound.
94 EXPECT_EQ(adjuster_.GetMaxAdjustedBitrateBps(), adjusted_bitrate_bps);
95 }
96
97 // Tests that large changes in target bitrate will result in immediate change
98 // in adjusted bitrate.
99 TEST_F(BitrateAdjusterTest, LargeTargetDelta) {
100 uint32_t target_bitrate_bps = 640000;
101 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
102 EXPECT_EQ(target_bitrate_bps, adjuster_.GetAdjustedBitrateBps());
103
104 float delta_pct = BitrateAdjuster::kBitrateTolerancePct * 2;
105
106 target_bitrate_bps = (1 + delta_pct) * target_bitrate_bps;
107 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
108 EXPECT_EQ(target_bitrate_bps, adjuster_.GetAdjustedBitrateBps());
109
110 target_bitrate_bps = (1 - delta_pct) * target_bitrate_bps;
111 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
112 EXPECT_EQ(target_bitrate_bps, adjuster_.GetAdjustedBitrateBps());
113 }
114
115 // Tests that small changes in target bitrate within tolerance will not affect
116 // adjusted bitrate immediately.
117 TEST_F(BitrateAdjusterTest, SmallTargetDelta) {
118 const uint32_t initial_target_bitrate_bps = 640000;
119 uint32_t target_bitrate_bps = initial_target_bitrate_bps;
120 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
121 EXPECT_EQ(initial_target_bitrate_bps, adjuster_.GetAdjustedBitrateBps());
122
123 float delta_pct = BitrateAdjuster::kBitrateTolerancePct / 2;
124
125 target_bitrate_bps = (1 + delta_pct) * target_bitrate_bps;
126 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
127 EXPECT_EQ(initial_target_bitrate_bps, adjuster_.GetAdjustedBitrateBps());
128
129 target_bitrate_bps = (1 - delta_pct) * target_bitrate_bps;
130 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
131 EXPECT_EQ(initial_target_bitrate_bps, adjuster_.GetAdjustedBitrateBps());
132 }
133
134 TEST_F(BitrateAdjusterTest, SmallTargetDeltaOverflow) {
135 const uint32_t initial_target_bitrate_bps = 640000;
136 uint32_t target_bitrate_bps = initial_target_bitrate_bps;
137 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
138 EXPECT_EQ(initial_target_bitrate_bps, adjuster_.GetAdjustedBitrateBps());
139
140 float delta_pct = BitrateAdjuster::kBitrateTolerancePct / 2;
141
142 target_bitrate_bps = (1 + delta_pct) * target_bitrate_bps;
143 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
144 EXPECT_EQ(initial_target_bitrate_bps, adjuster_.GetAdjustedBitrateBps());
145
146 // 1.05 * 1.05 is 1.1 which is greater than tolerance for the initial target
147 // bitrate. Since we didn't advance the clock the adjuster never updated.
148 target_bitrate_bps = (1 + delta_pct) * target_bitrate_bps;
149 adjuster_.SetTargetBitrateBps(target_bitrate_bps);
150 EXPECT_EQ(target_bitrate_bps, adjuster_.GetAdjustedBitrateBps());
151 }
152
153 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698