|
|
Created:
4 years, 10 months ago by hbos Modified:
4 years, 10 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDefault build flag |rtc_use_h264| to |proprietary_codecs|
if not on Android/iOS.
This means proprietary_codecs=1 && ffmpeg_branding=Chrome
can be used to enable this H.264 enc/dec implementation
instead of rtc_use_h264=1 && ffmpeg_branding=Chrome.
This is used by both Chromium trybots (but not default
Chromium build) and offical Chrome build, meaning we will
be able to test and enable H.264 in chromium.
This change would otherwise be enough to launch this
feature in Chrome, but because we do not want to do that
before we have chromium browser tests and are ready to flip
the switch, this CL prevents chromium from using H.264 just
yet: https://codereview.chromium.org/1641163002/ (landing
this after that CL).
BUG=chromium:500605, chromium:468365
Committed: https://crrev.com/7cd94f66ebfe5bf808d7dcb8da069d35f4a2b31a
Cr-Commit-Position: refs/heads/master@{#11506}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
hbos@webrtc.org changed reviewers: + kjellander@webrtc.org
Please take a look, kjellander.
Description was changed from ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/. BUG=chromium:500605, chromium:468365 ========== to ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (should land this AFTER that CL has landed). BUG=chromium:500605, chromium:468365 COMMIT=False ==========
Very nice. LGTM. Notice you only need to run compile trybots for this one (and set NOTRY=True for landing).
On 2016/02/04 14:00:36, kjellander (webrtc) wrote: > Very nice. LGTM. > Notice you only need to run compile trybots for this one (and set NOTRY=True for > landing). Please make it a habit to wrap description at 72 chars for Git log readability. See http://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting for info (there's an old chromium-dev thread somewhere about that).
Description was changed from ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (should land this AFTER that CL has landed). BUG=chromium:500605, chromium:468365 COMMIT=False ========== to ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (should land this AFTER that CL has landed). BUG=chromium:500605, chromium:468365 COMMIT=False NOTRY=True ==========
On 2016/02/04 14:02:16, kjellander (webrtc) wrote: > On 2016/02/04 14:00:36, kjellander (webrtc) wrote: > > Very nice. LGTM. > > Notice you only need to run compile trybots for this one (and set NOTRY=True > for > > landing). > > Please make it a habit to wrap description at 72 chars for Git log readability. > See > http://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting > for info (there's an old chromium-dev thread somewhere about that). OK! Will land as soon as blocking chromium CL has landed so we don't accidentally launch feature.
The CQ bit was checked by hbos@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
COMMIT=false detected. CQ is abandoning the patch.
Description was changed from ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (should land this AFTER that CL has landed). BUG=chromium:500605, chromium:468365 COMMIT=False NOTRY=True ========== to ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (landing this after that CL). BUG=chromium:500605, chromium:468365 COMMIT=False ==========
Description was changed from ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (landing this after that CL). BUG=chromium:500605, chromium:468365 COMMIT=False ========== to ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (landing this after that CL). BUG=chromium:500605, chromium:468365 ==========
The CQ bit was checked by hbos@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660403004/1
Message was sent while issue was closed.
Description was changed from ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (landing this after that CL). BUG=chromium:500605, chromium:468365 ========== to ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (landing this after that CL). BUG=chromium:500605, chromium:468365 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (landing this after that CL). BUG=chromium:500605, chromium:468365 ========== to ========== Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (landing this after that CL). BUG=chromium:500605, chromium:468365 Committed: https://crrev.com/7cd94f66ebfe5bf808d7dcb8da069d35f4a2b31a Cr-Commit-Position: refs/heads/master@{#11506} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7cd94f66ebfe5bf808d7dcb8da069d35f4a2b31a Cr-Commit-Position: refs/heads/master@{#11506}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/1677623002/ by hbos@webrtc.org. The reason for reverting is: Trybots red? Don't have time to intvestigate. |