Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1660403004: Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. (Closed)

Created:
4 years, 10 months ago by hbos
Modified:
4 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. This means proprietary_codecs=1 && ffmpeg_branding=Chrome can be used to enable this H.264 enc/dec implementation instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. This is used by both Chromium trybots (but not default Chromium build) and offical Chrome build, meaning we will be able to test and enable H.264 in chromium. This change would otherwise be enough to launch this feature in Chrome, but because we do not want to do that before we have chromium browser tests and are ready to flip the switch, this CL prevents chromium from using H.264 just yet: https://codereview.chromium.org/1641163002/ (landing this after that CL). BUG=chromium:500605, chromium:468365 Committed: https://crrev.com/7cd94f66ebfe5bf808d7dcb8da069d35f4a2b31a Cr-Commit-Position: refs/heads/master@{#11506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M webrtc/build/common.gypi View 1 chunk +14 lines, -10 lines 0 comments Download
M webrtc/build/webrtc.gni View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
hbos
Please take a look, kjellander.
4 years, 10 months ago (2016-02-04 12:50:47 UTC) #2
kjellander_webrtc
Very nice. LGTM. Notice you only need to run compile trybots for this one (and ...
4 years, 10 months ago (2016-02-04 14:00:36 UTC) #4
kjellander_webrtc
On 2016/02/04 14:00:36, kjellander (webrtc) wrote: > Very nice. LGTM. > Notice you only need ...
4 years, 10 months ago (2016-02-04 14:02:16 UTC) #5
hbos
On 2016/02/04 14:02:16, kjellander (webrtc) wrote: > On 2016/02/04 14:00:36, kjellander (webrtc) wrote: > > ...
4 years, 10 months ago (2016-02-04 14:16:42 UTC) #7
commit-bot: I haz the power
COMMIT=false detected. CQ is abandoning the patch.
4 years, 10 months ago (2016-02-05 16:49:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660403004/1
4 years, 10 months ago (2016-02-05 16:52:12 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 18:31:26 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7cd94f66ebfe5bf808d7dcb8da069d35f4a2b31a Cr-Commit-Position: refs/heads/master@{#11506}
4 years, 10 months ago (2016-02-05 18:31:31 UTC) #18
hbos
4 years, 10 months ago (2016-02-05 19:02:30 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1677623002/ by hbos@webrtc.org.

The reason for reverting is: Trybots red? Don't have time to intvestigate.

Powered by Google App Engine
This is Rietveld 408576698