Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: talk/app/webrtc/mediastreaminterface.h

Issue 1660103003: Delete FrameInput method and FrameInputWrapper class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Comment improvement. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/mediastreamtrackproxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/mediastreaminterface.h
diff --git a/talk/app/webrtc/mediastreaminterface.h b/talk/app/webrtc/mediastreaminterface.h
index 8d6feb02ef268a8115985d517e13cd0a40a018a3..2d2dc9ac9c5fb06d8aa25ba070f0f7f427cfd1ea 100644
--- a/talk/app/webrtc/mediastreaminterface.h
+++ b/talk/app/webrtc/mediastreaminterface.h
@@ -147,6 +147,26 @@ class VideoTrackInterface : public MediaStreamTrackInterface {
virtual VideoSourceInterface* GetSource() const = 0;
+ // Return the track input sink. I.e., frames sent to this sink are
+ // propagated to all renderers registered with the track. The
+ // returned sink must not change between calls. Currently, this
+ // method is used for remote tracks (VideoRtpReceiver); further
+ // refactoring is planned for this path, it's unclear if this method
+ // belongs here long term.
+
+ // We do this instead of simply implementing the
+ // VideoSourceInterface directly, because if we did the latter, we'd
+ // need an OnFrame method in VideoTrackProxy, with a thread jump on
+ // each call.
+
+ // TODO(nisse): It has a default implementation so that mock
+ // objects, in particular, chrome's MockWebRtcVideoTrack, doesn't
+ // need to know about it. Consider removing the implementation (or
+ // this comment) after refactoring dust settles.
+ virtual rtc::VideoSinkInterface<cricket::VideoFrame>* GetSink() {
+ return nullptr;
+ };
+
protected:
virtual ~VideoTrackInterface() {}
};
« no previous file with comments | « no previous file | talk/app/webrtc/mediastreamtrackproxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698