Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1660053002: iOS buildbot configurations. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
smut
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS buildbot configurations. This will make it possible for WebRTC to use the same buildbot scripts as Chrome's iOS bots. Buildbot changes are done in https://codereview.chromium.org/1659163003/ BUG=chromium:498746 NOTRY=True Committed: https://crrev.com/8e85a3f39ad101c4fbe82b54253c8361c88f064a Cr-Commit-Position: refs/heads/master@{#11468}

Patch Set 1 #

Patch Set 2 : Change all to use ninja #

Total comments: 2

Patch Set 3 : Enable Goma for all configs #

Patch Set 4 : Add use_analyze propery to trybot configs #

Patch Set 5 : Move all commit bot configs to client.webrtc.fyi for experimenting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, --1 lines) Patch
A + webrtc/build/ios/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS32_Debug.json View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS32_Release.json View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS32_Simulator_Debug.json View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Debug.json View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Debug_(GN).json View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Release.json View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Release_(GN).json View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/build/ios/client.webrtc.fyi/iOS64_Simulator_Debug.json View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A webrtc/build/ios/tests/common_tests.json View 1 chunk +7 lines, -0 lines 0 comments Download
A webrtc/build/ios/tryserver.webrtc/ios32_sim_dbg.json View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/build/ios/tryserver.webrtc/ios64_gn_dbg.json View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A webrtc/build/ios/tryserver.webrtc/ios64_gn_rel.json View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A webrtc/build/ios/tryserver.webrtc/ios64_sim_dbg.json View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/build/ios/tryserver.webrtc/ios_arm64_dbg.json View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A webrtc/build/ios/tryserver.webrtc/ios_arm64_rel.json View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A webrtc/build/ios/tryserver.webrtc/ios_dbg.json View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A webrtc/build/ios/tryserver.webrtc/ios_rel.json View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
smut
This seems reasonable but I noticed something about one of your GYP_DEFINES (applies to all ...
4 years, 10 months ago (2016-02-02 21:31:15 UTC) #2
kjellander_webrtc
iOS recipe module actually already allowed passing in the paths as parameters to the read_build_config ...
4 years, 10 months ago (2016-02-02 22:28:29 UTC) #3
smut
Seems lgtm
4 years, 10 months ago (2016-02-02 22:31:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660053002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660053002/80001
4 years, 10 months ago (2016-02-03 08:02:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660053002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660053002/80001
4 years, 10 months ago (2016-02-03 08:04:54 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-03 08:06:06 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 08:06:13 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8e85a3f39ad101c4fbe82b54253c8361c88f064a
Cr-Commit-Position: refs/heads/master@{#11468}

Powered by Google App Engine
This is Rietveld 408576698