Remove unimplemented VideoChannel code.

Remove unimplemented VideoChannel code.

Also removing a lot of dead testcases that were copied over and made
sense in the old implementation, now they just take space.

BUG=
R=pthatcher@google.com, pthatcher@webrtc.org

Committed: https://crrev.com/a6c39d99029e9787727c0b0c34fc8d13c8470c81
Cr-Commit-Position: refs/heads/master@{#11450}

[pbos-webrtc, 2016-02-01 15:25:54]

PTAL, this doesn't look like it's wired up above this layer so I'd like to
remove it until we need it, and in that case consider how it should actually
look

[pthatcher1, 2016-02-01 18:03:10]

https://codereview.webrtc.org/1658533003/diff/1/talk/media/webrtc/webrtcvideo...
File talk/media/webrtc/webrtcvideoengine2_unittest.cc (left):

https://codereview.webrtc.org/1658533003/diff/1/talk/media/webrtc/webrtcvideo...
talk/media/webrtc/webrtcvideoengine2_unittest.cc:810:
WEBRTC_DISABLED_BASE_TEST(AddRemoveRecvStreamAndRender);
This seems like a valuable unit test.  Why was it disabled before?

https://codereview.webrtc.org/1658533003/diff/1/talk/media/webrtc/webrtcvideo...
talk/media/webrtc/webrtcvideoengine2_unittest.cc:1397: }
Are we sure we want to never have unit tests for any of these things (leaky
bucket, auto bandwidth, lots of stuff around simulcast, etc)?

[pbos-webrtc, 2016-02-01 18:15:24]

https://codereview.webrtc.org/1658533003/diff/1/talk/media/webrtc/webrtcvideo...
File talk/media/webrtc/webrtcvideoengine2_unittest.cc (left):

https://codereview.webrtc.org/1658533003/diff/1/talk/media/webrtc/webrtcvideo...
talk/media/webrtc/webrtcvideoengine2_unittest.cc:810:
WEBRTC_DISABLED_BASE_TEST(AddRemoveRecvStreamAndRender);
On 2016/02/01 18:03:10, pthatcher1 wrote:
> This seems like a valuable unit test.  Why was it disabled before?

No idea why it was disabled before, but I'm not sure it's usable? The test
comment says that it should verify that no frames are rendered after a receive
stream is removed. In this implementation the only thing connecting this stream
to a video renderer is the stream object that's being removed. Am I missing
something?

https://codereview.webrtc.org/1658533003/diff/1/talk/media/webrtc/webrtcvideo...
talk/media/webrtc/webrtcvideoengine2_unittest.cc:1397: }
On 2016/02/01 18:03:10, pthatcher1 wrote:
> Are we sure we want to never have unit tests for any of these things (leaky
> bucket, auto bandwidth, lots of stuff around simulcast, etc)?

A lot of these (leaky bucket for instance) are no longer optional and are tested
elsewhere since they aren't configurable.

[pthatcher, 2016-02-01 18:21:52]

pthatcher@google.com changed reviewers:
+ pthatcher@google.com

[pthatcher, 2016-02-01 18:21:55]

lgtm

[pbos-webrtc, 2016-02-01 18:30:46]

Description was changed from

==========
Remove unimplemented VideoChannel code.

Also removing a lot of dead testcases that were copied over and made
sense in the old implementation, now they just take space.

BUG=
R=pthatcher@webrtc.org
==========

to

==========
Remove unimplemented VideoChannel code.

Also removing a lot of dead testcases that were copied over and made
sense in the old implementation, now they just take space.

BUG=
R=pthatcher@google.com, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a6c39d99029e9787727c0b0c3...
==========

[pbos-webrtc, 2016-02-01 18:30:47]

Committed patchset #1 (id:1) manually as
a6c39d99029e9787727c0b0c34fc8d13c8470c81.

[commit-bot: I haz the power, 2016-02-01 18:30:51]

Description was changed from

==========
Remove unimplemented VideoChannel code.

Also removing a lot of dead testcases that were copied over and made
sense in the old implementation, now they just take space.

BUG=
R=pthatcher@google.com, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a6c39d99029e9787727c0b0c3...
==========

to

==========
Remove unimplemented VideoChannel code.

Also removing a lot of dead testcases that were copied over and made
sense in the old implementation, now they just take space.

BUG=
R=pthatcher@google.com, pthatcher@webrtc.org

Committed: https://crrev.com/a6c39d99029e9787727c0b0c34fc8d13c8470c81
Cr-Commit-Position: refs/heads/master@{#11450}
==========

[commit-bot: I haz the power, 2016-02-01 18:30:52]

Patchset 1 (id:??) landed as
https://crrev.com/a6c39d99029e9787727c0b0c34fc8d13c8470c81
Cr-Commit-Position: refs/heads/master@{#11450}

[pthatcher1, 2016-02-01 18:36:46]

lgtm