webrtc/modules/video_coding/codecs/h264/h264.gypi - Issue 1657273002: Ability to disable the effects of |rtc_use_h264| with DisableRtcUseH264.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264.gypi

Issue 1657273002: Ability to disable the effects of |rtc_use_h264| with DisableRtcUseH264. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Gyp comment with #, not //, oops Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/video_coding/codecs/h264/h264.gypi

diff --git a/webrtc/modules/video_coding/codecs/h264/h264.gypi b/webrtc/modules/video_coding/codecs/h264/h264.gypi

index e82b0fd4cd39129a98709e1e139f8a6969124e2e..185c23de16e070bd36f99fabc2c931da71446a3c 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264.gypi

+++ b/webrtc/modules/video_coding/codecs/h264/h264.gypi

@@ -23,9 +23,12 @@

'h264_objc.mm',

}],

+ # TODO(hbos): Consider renaming this flag and the below macro to

+ # something which helps distinguish OpenH264/FFmpeg from other H264

+ # implementations.

['rtc_use_h264==1', {

'defines': [

- 'WEBRTC_THIRD_PARTY_H264',

+ 'WEBRTC_USE_H264',

'conditions': [

['rtc_initialize_ffmpeg==1', {

« no previous file with comments | « webrtc/modules/video_coding/codecs/h264/h264.cc ('k') | webrtc/modules/video_coding/codecs/h264/include/h264.h » ('j') | no next file with comments »