Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: webrtc/media/base/videosinkinterface.h

Issue 1655793003: Make cricket::VideoCapturer implement VideoSourceInterface (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed Android Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/videosinkinterface.h
diff --git a/webrtc/media/base/videosinkinterface.h b/webrtc/media/base/videosinkinterface.h
index 9b8ba318623e6b43b2db726f7f84f099f956de34..a4df749edf938feaf58a4b33c29ccec0ab465e8d 100644
--- a/webrtc/media/base/videosinkinterface.h
+++ b/webrtc/media/base/videosinkinterface.h
@@ -13,13 +13,22 @@
namespace rtc {
+struct VideoSinkCapabilities {
+ bool equals(const VideoSinkCapabilities& rh) const {
+ return can_apply_rotation == rh.can_apply_rotation;
+ }
pthatcher1 2016/02/03 15:38:36 Why not use operator== ?
perkj_webrtc 2016/02/08 14:32:01 because of style guide rules. But I think that is
+
+ // Tells the source whether the sink can handle rotation. By default, the
+ // rotation is applied by the source and the generated frame is up right.
+ bool can_apply_rotation = false;
+};
+
template <typename VideoFrameT>
class VideoSinkInterface {
public:
virtual void OnFrame(const VideoFrameT& frame) = 0;
-
protected:
- ~VideoSinkInterface() {}
+ virtual ~VideoSinkInterface() {}
};
} // namespace rtc

Powered by Google App Engine
This is Rietveld 408576698