Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: talk/app/webrtc/mediastreaminterface.h

Issue 1655793003: Make cricket::VideoCapturer implement VideoSourceInterface (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding VideoSourceInterface and letting cricket::VideoCapturer implement it Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/mediastreamprovider.h » ('j') | talk/media/base/videocapturer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/mediastreaminterface.h
diff --git a/talk/app/webrtc/mediastreaminterface.h b/talk/app/webrtc/mediastreaminterface.h
index 8d6feb02ef268a8115985d517e13cd0a40a018a3..2c5db118bfbef6b214ab879c28707e44770de25d 100644
--- a/talk/app/webrtc/mediastreaminterface.h
+++ b/talk/app/webrtc/mediastreaminterface.h
@@ -140,11 +140,19 @@ class VideoSourceInterface;
class VideoTrackInterface : public MediaStreamTrackInterface {
public:
- // Register a renderer that will render all frames received on this track.
- virtual void AddRenderer(VideoRendererInterface* renderer) = 0;
- // Deregister a renderer.
- virtual void RemoveRenderer(VideoRendererInterface* renderer) = 0;
-
+ // Backwards compatibility wrappers
+ virtual void AddRenderer(VideoRendererInterface* renderer) {
+ AddSink(renderer);
+ }
+ virtual void RemoveRenderer(VideoRendererInterface* renderer) {
+ RemoveSink(renderer);
+ }
+ // Register a sink that will receive all frames received on this
+ // track. Requires |sink| != nullptr.
+ virtual void AddSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0;
+ // Deregister a sink. Tolerates |sink| == nullptr.
+ virtual void RemoveSink(
+ rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0;
virtual VideoSourceInterface* GetSource() const = 0;
protected:
« no previous file with comments | « no previous file | talk/app/webrtc/mediastreamprovider.h » ('j') | talk/media/base/videocapturer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698