Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: webrtc/media/webrtc/webrtcvideocapturer.h

Issue 1655793003: Make cricket::VideoCapturer implement VideoSourceInterface (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments. Removed AddSink Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/webrtc/webrtcvideocapturer.h
diff --git a/webrtc/media/webrtc/webrtcvideocapturer.h b/webrtc/media/webrtc/webrtcvideocapturer.h
index ef4dea48a176a733e3d90dc28987ee030708f2aa..d32c5c451af1c39eb7246864d1c08e0556d10bcf 100644
--- a/webrtc/media/webrtc/webrtcvideocapturer.h
+++ b/webrtc/media/webrtc/webrtcvideocapturer.h
@@ -11,8 +11,6 @@
#ifndef WEBRTC_MEDIA_WEBRTC_WEBRTCVIDEOCAPTURER_H_
#define WEBRTC_MEDIA_WEBRTC_WEBRTCVIDEOCAPTURER_H_
-#ifdef HAVE_WEBRTC_VIDEO
nisse-webrtc 2016/02/09 14:10:54 Why are these conditionals removed?
perkj_webrtc 2016/02/10 10:54:37 They are meaningless and should be removed. They
-
#include <string>
#include <vector>
@@ -50,15 +48,15 @@ class WebRtcVideoCapturer : public VideoCapturer,
bool Init(webrtc::VideoCaptureModule* module);
// Override virtual methods of the parent class VideoCapturer.
- virtual bool GetBestCaptureFormat(const VideoFormat& desired,
- VideoFormat* best_format);
- virtual CaptureState Start(const VideoFormat& capture_format);
- virtual void Stop();
- virtual bool IsRunning();
- virtual bool IsScreencast() const { return false; }
- virtual bool SetApplyRotation(bool enable);
+ bool GetBestCaptureFormat(const VideoFormat& desired,
+ VideoFormat* best_format) override;
+ CaptureState Start(const VideoFormat& capture_format) override;
+ void Stop() override;
+ bool IsRunning() override;
+ bool IsScreencast() const override { return false; }
protected:
+ void OnSinkVideoWantsChanged(const rtc::VideoWants& wants) override;
// Override virtual methods of the parent class VideoCapturer.
virtual bool GetPreferredFourccs(std::vector<uint32_t>* fourccs);
@@ -95,5 +93,4 @@ struct WebRtcCapturedFrame : public CapturedFrame {
} // namespace cricket
-#endif // HAVE_WEBRTC_VIDEO
#endif // WEBRTC_MEDIA_WEBRTC_WEBRTCVIDEOCAPTURER_H_

Powered by Google App Engine
This is Rietveld 408576698