Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: talk/app/webrtc/videotrackrenderers.cc

Issue 1655793003: Make cricket::VideoCapturer implement VideoSourceInterface (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding VideoSourceInterface and letting cricket::VideoCapturer implement it Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
11 * this list of conditions and the following disclaimer in the documentation 11 * this list of conditions and the following disclaimer in the documentation
12 * and/or other materials provided with the distribution. 12 * and/or other materials provided with the distribution.
13 * 3. The name of the author may not be used to endorse or promote products 13 * 3. The name of the author may not be used to endorse or promote products
14 * derived from this software without specific prior written permission. 14 * derived from this software without specific prior written permission.
15 * 15 *
16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED 16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
17 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF 17 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
18 * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO 18 * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
19 * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 19 * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
20 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 20 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; 21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, 22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF 24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26 */ 26 */
27 27
28 #include "webrtc/base/checks.h"
28 #include "talk/app/webrtc/videotrackrenderers.h" 29 #include "talk/app/webrtc/videotrackrenderers.h"
29 #include "talk/media/webrtc/webrtcvideoframe.h" 30 #include "talk/media/webrtc/webrtcvideoframe.h"
30 31
31 namespace webrtc { 32 namespace webrtc {
32 33
33 VideoTrackRenderers::VideoTrackRenderers() : enabled_(true) { 34 VideoTrackRenderers::VideoTrackRenderers() : enabled_(true) {
34 } 35 }
35 36
36 VideoTrackRenderers::~VideoTrackRenderers() { 37 VideoTrackRenderers::~VideoTrackRenderers() {
37 } 38 }
38 39
39 void VideoTrackRenderers::AddRenderer(VideoRendererInterface* renderer) { 40 void VideoTrackRenderers::AddSink(
40 if (!renderer) { 41 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) {
42 RTC_DCHECK (sink != nullptr);
43 if (!sink) {
41 return; 44 return;
42 } 45 }
43 rtc::CritScope cs(&critical_section_); 46 rtc::CritScope cs(&critical_section_);
44 renderers_.insert(renderer); 47 sinks_.insert(sink);
45 } 48 }
46 49
47 void VideoTrackRenderers::RemoveRenderer(VideoRendererInterface* renderer) { 50 void VideoTrackRenderers::RemoveSink(
51 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) {
48 rtc::CritScope cs(&critical_section_); 52 rtc::CritScope cs(&critical_section_);
49 renderers_.erase(renderer); 53 sinks_.erase(sink);
50 } 54 }
51 55
52 void VideoTrackRenderers::SetEnabled(bool enable) { 56 void VideoTrackRenderers::SetEnabled(bool enable) {
53 rtc::CritScope cs(&critical_section_); 57 rtc::CritScope cs(&critical_section_);
54 enabled_ = enable; 58 enabled_ = enable;
55 } 59 }
56 60
57 bool VideoTrackRenderers::RenderFrame(const cricket::VideoFrame* frame) { 61 bool VideoTrackRenderers::RenderFrame(const cricket::VideoFrame* frame) {
58 { 62 {
59 rtc::CritScope cs(&critical_section_); 63 rtc::CritScope cs(&critical_section_);
60 if (enabled_) { 64 if (enabled_) {
61 RenderFrameToRenderers(frame); 65 SendFrameToSinks(*frame);
62 return true; 66 return true;
63 } 67 }
64 } 68 }
65 69
66 // Generate the black frame outside of the critical section. Note 70 // Generate the black frame outside of the critical section. Note
67 // that this may result in unexpected frame order, in the unlikely 71 // that this may result in unexpected frame order, in the unlikely
68 // case that RenderFrame is called from multiple threads without 72 // case that RenderFrame is called from multiple threads without
69 // proper serialization, and the track is switched from disabled to 73 // proper serialization, and the track is switched from disabled to
70 // enabled in the middle of the first call. 74 // enabled in the middle of the first call.
71 cricket::WebRtcVideoFrame black(new rtc::RefCountedObject<I420Buffer>( 75 cricket::WebRtcVideoFrame black(new rtc::RefCountedObject<I420Buffer>(
72 static_cast<int>(frame->GetWidth()), 76 static_cast<int>(frame->GetWidth()),
73 static_cast<int>(frame->GetHeight())), 77 static_cast<int>(frame->GetHeight())),
74 frame->GetTimeStamp(), 78 frame->GetTimeStamp(),
75 frame->GetVideoRotation()); 79 frame->GetVideoRotation());
76 black.SetToBlack(); 80 black.SetToBlack();
77 81
78 { 82 {
79 rtc::CritScope cs(&critical_section_); 83 rtc::CritScope cs(&critical_section_);
80 // Check enabled_ flag again, since the track might have been 84 // Check enabled_ flag again, since the track might have been
81 // enabled while we generated the black frame. I think the 85 // enabled while we generated the black frame. I think the
82 // enabled-ness ought to be applied at the track output, and hence 86 // enabled-ness ought to be applied at the track output, and hence
83 // an enabled track shouldn't send any blacked out frames. 87 // an enabled track shouldn't send any blacked out frames.
84 RenderFrameToRenderers(enabled_ ? frame : &black); 88 SendFrameToSinks(enabled_ ? *frame : black);
85 89
86 return true; 90 return true;
87 } 91 }
88 } 92 }
89 93
90 // Called with critical_section_ already locked 94 // Called with critical_section_ already locked
91 void VideoTrackRenderers::RenderFrameToRenderers( 95 void VideoTrackRenderers::SendFrameToSinks(const cricket::VideoFrame& frame) {
92 const cricket::VideoFrame* frame) { 96 for (auto* sink : sinks_) {
93 for (VideoRendererInterface* renderer : renderers_) { 97 sink->OnFrame(frame);
94 renderer->RenderFrame(frame);
95 } 98 }
96 } 99 }
97 100
98 } // namespace webrtc 101 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698