Remove the network with empty name or NONE connection type from the network list.

Remove the network with empty name or NONE connection type from the network list.
In some device (e.g. Galaxy s6), the OS returns a list of network containing
one that has empty network name or NONE connection type, which cannot be used and cause crash to the app.

BUG=

Committed: https://crrev.com/9031d6366f281de69e750c77063622e349c8cb03
Cr-Commit-Position: refs/heads/master@{#11482}

[honghaiz3, 2016-02-03 22:10:08]

Description was changed from

==========
Remove the network with empty name or NONE connection type from the network
list.
In some device (e.g. Galaxy s6), the OS returns a list of network containing
one that has empty network name or NONE connection type, which cannot be used.

BUG=
==========

to

==========
Remove the network with empty name or NONE connection type from the network
list.
In some device (e.g. Galaxy s6), the OS returns a list of network containing
one that has empty network name or NONE connection type, which cannot be used
and cause crash to the app.

BUG=
==========

[honghaiz3, 2016-02-03 22:10:41]

honghaiz@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[pthatcher1, 2016-02-03 22:28:57]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-02-03 22:28:57]

lgtm

Land if it's urgent, but then follow up by adding a unit test.  

Also, should we do a check like this lower down in the stack?

[AlexG, 2016-02-03 22:35:28]

https://codereview.webrtc.org/1655313005/diff/1/talk/app/webrtc/java/android/...
File talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java
(right):

https://codereview.webrtc.org/1655313005/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java:240:
NetworkInformation[] getActiveNetworkList() {
May be return List<NetworkInformation> from this function making below code a
little simpler? Or you pass it to JNI later?

[AlexG, 2016-02-03 22:35:53]

lgtm

[honghaiz3, 2016-02-03 23:30:05]

On 2016/02/03 22:28:57, pthatcher1 wrote:
> lgtm
> 
> Land if it's urgent, but then follow up by adding a unit test.  
> 
> Also, should we do a check like this lower down in the stack?
We can do this either at the topmost layer (here) which is the source of the
information, 
or at the bottom (which is at the jni c++ code). It is not much more beneficial
to pass those information (that will be removed) along. 
Plus, it would only make the logic in the jni more complicated to check the
nullness of the objects there.

[honghaiz3, 2016-02-04 04:42:28]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-02-04 04:42:28]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1655313005/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2016-02-04 04:42:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1655313005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1655313005/20001

[honghaiz3, 2016-02-04 04:43:29]

https://codereview.webrtc.org/1655313005/diff/1/talk/app/webrtc/java/android/...
File talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java
(right):

https://codereview.webrtc.org/1655313005/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java:240:
NetworkInformation[] getActiveNetworkList() {
On 2016/02/03 22:35:27, AlexG wrote:
> May be return List<NetworkInformation> from this function making below code a
> little simpler? Or you pass it to JNI later?

Done.

[commit-bot: I haz the power, 2016-02-04 05:45:28]

Description was changed from

==========
Remove the network with empty name or NONE connection type from the network
list.
In some device (e.g. Galaxy s6), the OS returns a list of network containing
one that has empty network name or NONE connection type, which cannot be used
and cause crash to the app.

BUG=
==========

to

==========
Remove the network with empty name or NONE connection type from the network
list.
In some device (e.g. Galaxy s6), the OS returns a list of network containing
one that has empty network name or NONE connection type, which cannot be used
and cause crash to the app.

BUG=
==========

[commit-bot: I haz the power, 2016-02-04 05:45:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-04 05:45:35]

Description was changed from

==========
Remove the network with empty name or NONE connection type from the network
list.
In some device (e.g. Galaxy s6), the OS returns a list of network containing
one that has empty network name or NONE connection type, which cannot be used
and cause crash to the app.

BUG=
==========

to

==========
Remove the network with empty name or NONE connection type from the network
list.
In some device (e.g. Galaxy s6), the OS returns a list of network containing
one that has empty network name or NONE connection type, which cannot be used
and cause crash to the app.

BUG=

Committed: https://crrev.com/9031d6366f281de69e750c77063622e349c8cb03
Cr-Commit-Position: refs/heads/master@{#11482}
==========

[commit-bot: I haz the power, 2016-02-04 05:45:36]

Patchset 2 (id:??) landed as
https://crrev.com/9031d6366f281de69e750c77063622e349c8cb03
Cr-Commit-Position: refs/heads/master@{#11482}

[honghaiz3, 2016-02-04 06:05:32]

On 2016/02/03 22:28:57, pthatcher1 wrote:
> lgtm
> 
> Land if it's urgent, but then follow up by adding a unit test.  
> 
> Also, should we do a check like this lower down in the stack?

Will add tests in a separate CL.