Extra logging for HW codec.

Extra logging for HW codec.

- Add extra logging for Android HW codec corner cases
when frames are dropped or resolution is changed.
- Use presentation timestamps for decoded frame logging.
- Enable key frame sending on long frame gap for
H.264 codec.

BUG=b/26504665

Committed: https://crrev.com/94291480b63e3fcc1fa786af3d2a51f3c496612f
Cr-Commit-Position: refs/heads/master@{#11452}

[AlexG, 2016-01-30 01:16:53]

glaznev@webrtc.org changed reviewers:
+ perkj@webrtc.org

[AlexG, 2016-01-30 01:16:53]

PTAL

[perkj_webrtc, 2016-02-01 09:20:54]

lgtm with comments addressed

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
File talk/app/webrtc/java/jni/androidmediadecoder_jni.cc (right):

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediadecoder_jni.cc:272: j_info_size_field_ =
GetFieldID(
duplicate set

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
File talk/app/webrtc/java/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:608: if ((codecType_ ==
kVideoCodecVP8 || codecType_ == kVideoCodecH264)
remove check for codectType_ ? Always do this regardless of codec type.
Does this make the quality better for bad network conditions with H264? I
assigned a bug regarding that to pbos.

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:1118: << ", encTime: " <<
Can this be aligned in a more readable way.

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:1122: start_time_ms_ =
GetCurrentTimeMs();
change name of start_time_ms_  to something more descriptive. How about
log_statistics_time_ ?

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/src/org/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (right):

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:617:
(info.presentationTimeUs + 500) / 1000,
TimeUnit.MICROSECONDS.toMillis()

[AlexG, 2016-02-01 20:13:35]

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
File talk/app/webrtc/java/jni/androidmediadecoder_jni.cc (right):

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediadecoder_jni.cc:272: j_info_size_field_ =
GetFieldID(
On 2016/02/01 09:20:53, perkj_webrtc wrote:
> duplicate set

Done.

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
File talk/app/webrtc/java/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:608: if ((codecType_ ==
kVideoCodecVP8 || codecType_ == kVideoCodecH264)
On 2016/02/01 09:20:53, perkj_webrtc wrote:
> remove check for codectType_ ? Always do this regardless of codec type.
> Does this make the quality better for bad network conditions with H264? I
> assigned a bug regarding that to pbos.

Done.

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:1118: << ", encTime: " <<
On 2016/02/01 09:20:53, perkj_webrtc wrote:
> Can this be aligned in a more readable way.

Done. And for other similar logs in encoder and decoder code.

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:1122: start_time_ms_ =
GetCurrentTimeMs();
On 2016/02/01 09:20:53, perkj_webrtc wrote:
> change name of start_time_ms_  to something more descriptive. How about
> log_statistics_time_ ? 

Done.

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/src/org/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (right):

https://codereview.webrtc.org/1653523003/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:617:
(info.presentationTimeUs + 500) / 1000,
On 2016/02/01 09:20:54, perkj_webrtc wrote:
> TimeUnit.MICROSECONDS.toMillis() 

Done.

[AlexG, 2016-02-01 20:14:55]

The CQ bit was checked by glaznev@webrtc.org

[AlexG, 2016-02-01 20:14:56]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1653523003/#ps20001 (title:
"Address comments")

[commit-bot: I haz the power, 2016-02-01 20:15:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1653523003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1653523003/20001

[commit-bot: I haz the power, 2016-02-01 21:17:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-01 21:17:36]

Description was changed from

==========
Extra logging for HW codec.

- Add extra logging for Android HW codec corner cases
when frames are dropped or resolution is changed.
- Use presentation timestamps for decoded frame logging.
- Enable key frame sending on long frame gap for
H.264 codec.

BUG=b/26504665
==========

to

==========
Extra logging for HW codec.

- Add extra logging for Android HW codec corner cases
when frames are dropped or resolution is changed.
- Use presentation timestamps for decoded frame logging.
- Enable key frame sending on long frame gap for
H.264 codec.

BUG=b/26504665

Committed: https://crrev.com/94291480b63e3fcc1fa786af3d2a51f3c496612f
Cr-Commit-Position: refs/heads/master@{#11452}
==========

[commit-bot: I haz the power, 2016-02-01 21:17:37]

Patchset 2 (id:??) landed as
https://crrev.com/94291480b63e3fcc1fa786af3d2a51f3c496612f
Cr-Commit-Position: refs/heads/master@{#11452}