Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1652983002: Remove mutable from rtc::CriticalSections. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, andresp, peah-webrtc, minyue-webrtc, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove mutable from rtc::CriticalSections. A couple of mutables were added after last removal of mutables, so removing those. rtc::CriticalSection is const-lockable. BUG= R=tommi@webrtc.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M webrtc/video/call_stats.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/encoder_state_feedback.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/payload_router.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_capture_input.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_channel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_remb.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.h View 5 chunks +7 lines, -7 lines 0 comments Download
M webrtc/voice_engine/channel_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/dtmf_inband.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/level_indicator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/shared_data.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/statistics.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/conference_transport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/after_initialization_fixture.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pbos-webrtc
PTAL, done with regex: Replacing with 's/mutable rtc::CriticalSection/rtc::CriticalSection/g' in files: webrtc/video/call_stats.h webrtc/video/encoder_state_feedback.h webrtc/video/payload_router.h webrtc/video/video_capture_input.h webrtc/video/vie_channel.h ...
4 years, 10 months ago (2016-02-01 15:37:25 UTC) #1
tommi
lgtm
4 years, 10 months ago (2016-02-01 16:00:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652983002/1
4 years, 10 months ago (2016-02-01 16:00:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 17:01:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 17:01:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8de1154c9dbf73d44a71d09827660c1fe13e2d6
Cr-Commit-Position: refs/heads/master@{#11447}

Powered by Google App Engine
This is Rietveld 408576698