Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1652973002: Revert of Added validation between RTP and RTCP timestamps (Closed)

Created:
4 years, 10 months ago by danilchap
Modified:
4 years, 10 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added validation between RTP and RTCP timestamps (patchset #7 id:120001 of https://codereview.webrtc.org/1633843003/ ) Reason for revert: May be the reason for mac_asan timeout Original issue's description: > Changed test to validate rtp timstamps not just in RTP packets but also in RTCP Sender Reports. > Altered it to accept negative value since it is normal for RTCP packet coming before RTP packet to have slightly later time. > > BUG=webrtc:5433 > > Committed: https://crrev.com/f4b9c775122b463db7eb2c4101603759a0d00caf > Cr-Commit-Position: refs/heads/master@{#11417} TBR=pbos@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5433 Committed: https://crrev.com/34877eeec91b3a86cc14073cfe696b6dddc9aabd Cr-Commit-Position: refs/heads/master@{#11446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -54 lines) Patch
M webrtc/video/end_to_end_tests.cc View 6 chunks +33 lines, -54 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
danilchap
Created Revert of Added validation between RTP and RTCP timestamps
4 years, 10 months ago (2016-02-01 15:22:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652973002/1
4 years, 10 months ago (2016-02-01 15:23:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652973002/1
4 years, 10 months ago (2016-02-01 15:32:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652973002/1
4 years, 10 months ago (2016-02-01 16:02:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 16:25:08 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 16:25:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34877eeec91b3a86cc14073cfe696b6dddc9aabd
Cr-Commit-Position: refs/heads/master@{#11446}

Powered by Google App Engine
This is Rietveld 408576698