Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1650993004: Add iOS tracing. (Closed)

Created:
4 years, 10 months ago by tkchin_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add iOS tracing. BUG= Committed: https://crrev.com/d1fb26d457fd6628b9a92769d03bd1576a3e1730 Cr-Commit-Position: refs/heads/master@{#11469}

Patch Set 1 #

Patch Set 2 : BUILD.gn #

Total comments: 1

Patch Set 3 : Update comment #

Patch Set 4 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -3 lines) Patch
M webrtc/base/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A + webrtc/base/objc/RTCMacros.h View 2 chunks +5 lines, -3 lines 0 comments Download
A webrtc/base/objc/RTCTracing.h View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A webrtc/base/objc/RTCTracing.mm View 1 chunk +29 lines, -0 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ARDAppClient.m View 4 chunks +21 lines, -0 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
tkchin_webrtc
4 years, 10 months ago (2016-02-02 10:00:42 UTC) #2
Chuck
lgtm https://codereview.webrtc.org/1650993004/diff/20001/webrtc/base/objc/RTCTracing.h File webrtc/base/objc/RTCTracing.h (right): https://codereview.webrtc.org/1650993004/diff/20001/webrtc/base/objc/RTCTracing.h#newcode16 webrtc/base/objc/RTCTracing.h:16: /** Starts capture to specified file. Must be ...
4 years, 10 months ago (2016-02-02 16:32:50 UTC) #3
hjon_webrtc
lgtm
4 years, 10 months ago (2016-02-02 17:58:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650993004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650993004/60001
4 years, 10 months ago (2016-02-03 08:15:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3203)
4 years, 10 months ago (2016-02-03 08:22:15 UTC) #9
tkchin_webrtc
+kjellander for BUILD.gn stamp
4 years, 10 months ago (2016-02-03 08:28:16 UTC) #12
kjellander_webrtc
lgtm
4 years, 10 months ago (2016-02-03 09:35:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650993004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650993004/60001
4 years, 10 months ago (2016-02-03 09:50:02 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-03 09:51:22 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 09:51:28 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d1fb26d457fd6628b9a92769d03bd1576a3e1730
Cr-Commit-Position: refs/heads/master@{#11469}

Powered by Google App Engine
This is Rietveld 408576698