Make ECDSA default for RTCPeerConnection

Make ECDSA default for RTCPeerConnection

BUG=

Committed: https://crrev.com/ab8f82ffe0c01813bba3f183eb2f17a48d5a853c
Cr-Commit-Position: refs/heads/master@{#11409}

[tkchin_webrtc, 2016-01-27 22:23:44]

Patchset #1 (id:1) has been deleted

[tkchin_webrtc, 2016-01-27 22:33:03]

Patchset #1 (id:20001) has been deleted

[tkchin_webrtc, 2016-01-27 22:34:01]

Description was changed from

==========
Make ECDSA default for RTCPeerConnection

BUG=
==========

to

==========
Make ECDSA default for RTCPeerConnection

BUG=
==========

[tkchin_webrtc, 2016-01-27 22:34:01]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org, hjon@webrtc.org

[tkchin_webrtc, 2016-01-27 22:35:49]

Jon - I made some changes to RTCConfiguration, let me know if you disagree with
the changes. Basically I think we don't need a special ctor for all the fields
since we're treating this as a struct anyway and I don't see people needing an
init for all the vars at once. Also, it doesn't seem like we will need to
initFromNativeConfiguration anywhere so I removed that for simplicity with this
ECDSA change.

[hjon_webrtc, 2016-01-28 00:01:35]

lgtm

Both of those changes make sense to me.

[hjon_webrtc, 2016-01-28 00:01:59]

https://codereview.webrtc.org/1649533002/diff/60001/webrtc/api/objc/RTCConfig...
File webrtc/api/objc/RTCConfiguration.h (right):

https://codereview.webrtc.org/1649533002/diff/60001/webrtc/api/objc/RTCConfig...
webrtc/api/objc/RTCConfiguration.h:72: /** Key type used to generate SSL
identity. Default is EC. */
nit: "Default is ECDSA." ? Doesn't seem like a big deal, but at my first glance
I wasn't sure if there was a third type I had missed in the enum.

[tkchin_webrtc, 2016-01-28 00:43:08]

https://codereview.webrtc.org/1649533002/diff/60001/webrtc/api/objc/RTCConfig...
File webrtc/api/objc/RTCConfiguration.h (right):

https://codereview.webrtc.org/1649533002/diff/60001/webrtc/api/objc/RTCConfig...
webrtc/api/objc/RTCConfiguration.h:72: /** Key type used to generate SSL
identity. Default is EC. */
On 2016/01/28 00:01:59, hjon_webrtc wrote:
> nit: "Default is ECDSA." ? Doesn't seem like a big deal, but at my first
glance
> I wasn't sure if there was a third type I had missed in the enum.

Technically the key type is just EC (Elliptic Curve). ECDSA is the signing algo.

[tkchin_webrtc, 2016-01-28 01:16:31]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-01-28 01:16:31]

The patchset sent to the CQ was uploaded after l-g-t-m from hjon@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1649533002/#ps80001 (title:
"Update comment")

[commit-bot: I haz the power, 2016-01-28 01:16:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649533002/80001

[Chuck, 2016-01-28 01:21:58]

lgtm as well

[commit-bot: I haz the power, 2016-01-28 01:50:15]

Description was changed from

==========
Make ECDSA default for RTCPeerConnection

BUG=
==========

to

==========
Make ECDSA default for RTCPeerConnection

BUG=
==========

[commit-bot: I haz the power, 2016-01-28 01:50:15]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-01-28 01:50:25]

Description was changed from

==========
Make ECDSA default for RTCPeerConnection

BUG=
==========

to

==========
Make ECDSA default for RTCPeerConnection

BUG=

Committed: https://crrev.com/ab8f82ffe0c01813bba3f183eb2f17a48d5a853c
Cr-Commit-Position: refs/heads/master@{#11409}
==========

[commit-bot: I haz the power, 2016-01-28 01:50:26]

Patchset 3 (id:??) landed as
https://crrev.com/ab8f82ffe0c01813bba3f183eb2f17a48d5a853c
Cr-Commit-Position: refs/heads/master@{#11409}