Stop processing any incoming packets when turn port is disconnected.

Stop processing any incoming packets when turn port is disconnected.

If it still handle packets, when a ping arrives, it will pass the packet to p2ptransportchannel, eventually causing an ASSERT error there (when p2ptransportchannel tries to create a connection from the ping request from unknown address).

BUG=

Committed: https://crrev.com/9dfed79f3fb307e4bc3bd5a2da059de7940ec081
Cr-Commit-Position: refs/heads/master@{#11430}

[honghaiz3, 2016-01-29 01:29:17]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-01-29 01:31:50]

Description was changed from

==========
Stop processing any incoming packets when turn port is disconnected.

BUG=
==========

to

==========
Stop processing any incoming packets when turn port is disconnected.

If it still handle packets, when a ping arrives, it will pass the packet to
p2ptransportchannel, eventually causing an ASSERT error there (when
p2ptransportchannel tries to create a connection from the ping request from
unknown address). 

BUG=
==========

[honghaiz3, 2016-01-29 01:32:22]

honghaiz@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[pthatcher1, 2016-01-29 17:38:40]

lgtm

[Taylor Brandstetter, 2016-01-29 18:43:22]

lgtm, with just a comment and a nit

https://codereview.chromium.org/1649493006/diff/20001/webrtc/p2p/base/turnport.h
File webrtc/p2p/base/turnport.h (right):

https://codereview.chromium.org/1649493006/diff/20001/webrtc/p2p/base/turnpor...
webrtc/p2p/base/turnport.h:156: void Close();
I don't like making methods public only for the sake of testing. However, if the
only time a TURN port is expected to be closed is when it encounters a refresh
error, that would be difficult to reproduce in a test due to the long time
required.

Maybe this is one of the tests we can fix up once we have a "virtual clock"
system.

https://codereview.chromium.org/1649493006/diff/20001/webrtc/p2p/base/turnpor...
File webrtc/p2p/base/turnport_unittest.cc (right):

https://codereview.chromium.org/1649493006/diff/20001/webrtc/p2p/base/turnpor...
webrtc/p2p/base/turnport_unittest.cc:737: // SignalUknownAddress.
SignalUkownAddress => SignalUnknownAddress

[honghaiz3, 2016-01-29 19:40:14]

Thanks!

https://codereview.webrtc.org/1649493006/diff/20001/webrtc/p2p/base/turnport.h
File webrtc/p2p/base/turnport.h (right):

https://codereview.webrtc.org/1649493006/diff/20001/webrtc/p2p/base/turnport....
webrtc/p2p/base/turnport.h:156: void Close();
On 2016/01/29 18:43:22, Taylor Brandstetter wrote:
> I don't like making methods public only for the sake of testing. However, if
the
> only time a TURN port is expected to be closed is when it encounters a refresh
> error, that would be difficult to reproduce in a test due to the long time
> required.
> 
> Maybe this is one of the tests we can fix up once we have a "virtual clock"
> system.

Acknowledged.

https://codereview.webrtc.org/1649493006/diff/20001/webrtc/p2p/base/turnport_...
File webrtc/p2p/base/turnport_unittest.cc (right):

https://codereview.webrtc.org/1649493006/diff/20001/webrtc/p2p/base/turnport_...
webrtc/p2p/base/turnport_unittest.cc:737: // SignalUknownAddress.
On 2016/01/29 18:43:22, Taylor Brandstetter wrote:
> SignalUkownAddress => SignalUnknownAddress

Done.

[honghaiz3, 2016-01-29 19:40:36]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-01-29 19:40:37]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1649493006/#ps40001 (title:
" ")

[commit-bot: I haz the power, 2016-01-29 19:40:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649493006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649493006/40001

[commit-bot: I haz the power, 2016-01-29 21:22:33]

Description was changed from

==========
Stop processing any incoming packets when turn port is disconnected.

If it still handle packets, when a ping arrives, it will pass the packet to
p2ptransportchannel, eventually causing an ASSERT error there (when
p2ptransportchannel tries to create a connection from the ping request from
unknown address). 

BUG=
==========

to

==========
Stop processing any incoming packets when turn port is disconnected.

If it still handle packets, when a ping arrives, it will pass the packet to
p2ptransportchannel, eventually causing an ASSERT error there (when
p2ptransportchannel tries to create a connection from the ping request from
unknown address). 

BUG=
==========

[commit-bot: I haz the power, 2016-01-29 21:22:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-01-29 21:22:44]

Description was changed from

==========
Stop processing any incoming packets when turn port is disconnected.

If it still handle packets, when a ping arrives, it will pass the packet to
p2ptransportchannel, eventually causing an ASSERT error there (when
p2ptransportchannel tries to create a connection from the ping request from
unknown address). 

BUG=
==========

to

==========
Stop processing any incoming packets when turn port is disconnected.

If it still handle packets, when a ping arrives, it will pass the packet to
p2ptransportchannel, eventually causing an ASSERT error there (when
p2ptransportchannel tries to create a connection from the ping request from
unknown address).

BUG=

Committed: https://crrev.com/9dfed79f3fb307e4bc3bd5a2da059de7940ec081
Cr-Commit-Position: refs/heads/master@{#11430}
==========

[commit-bot: I haz the power, 2016-01-29 21:22:45]

Patchset 2 (id:??) landed as
https://crrev.com/9dfed79f3fb307e4bc3bd5a2da059de7940ec081
Cr-Commit-Position: refs/heads/master@{#11430}