Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: talk/media/webrtc/webrtcvideoengine2.cc

Issue 1649493004: Support multiple rtx codecs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove some more code. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/webrtc/webrtcvideoengine2.cc
diff --git a/talk/media/webrtc/webrtcvideoengine2.cc b/talk/media/webrtc/webrtcvideoengine2.cc
index 1fc9dd52d42b714de72d62fcf583cec74dfc1b44..84320c029db55825211d3d633edcb95c4d2b6b55 100644
--- a/talk/media/webrtc/webrtcvideoengine2.cc
+++ b/talk/media/webrtc/webrtcvideoengine2.cc
@@ -357,7 +357,6 @@ std::vector<VideoCodec> DefaultVideoCodecList() {
if (CodecIsInternallySupported(kVp9CodecName)) {
codecs.push_back(MakeVideoCodecWithDefaultFeedbackParams(kDefaultVp9PlType,
kVp9CodecName));
- // TODO(andresp): Add rtx codec for vp9 and verify it works.
}
if (CodecIsInternallySupported(kH264CodecName)) {
codecs.push_back(MakeVideoCodecWithDefaultFeedbackParams(kDefaultH264PlType,
@@ -365,7 +364,13 @@ std::vector<VideoCodec> DefaultVideoCodecList() {
}
codecs.push_back(
VideoCodec::CreateRtxCodec(kDefaultRtxVp8PlType, kDefaultVp8PlType));
+ if (CodecIsInternallySupported(kVp9CodecName)) {
+ codecs.push_back(
+ VideoCodec::CreateRtxCodec(kDefaultRtxVp9PlType, kDefaultVp9PlType));
+ }
codecs.push_back(VideoCodec(kDefaultRedPlType, kRedCodecName));
+ codecs.push_back(
+ VideoCodec::CreateRtxCodec(kDefaultRtxRedPlType, kDefaultRedPlType));
codecs.push_back(VideoCodec(kDefaultUlpfecType, kUlpfecCodecName));
return codecs;
}

Powered by Google App Engine
This is Rietveld 408576698