webrtc/p2p/base/p2ptransportchannel.h - Issue 1648813004: Remove candidates when doing continual gathering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/p2ptransportchannel.h

Issue 1648813004: Remove candidates when doing continual gathering (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Delete ice_candidate when it is removed and add a test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/p2p/base/p2ptransportchannel.h

diff --git a/webrtc/p2p/base/p2ptransportchannel.h b/webrtc/p2p/base/p2ptransportchannel.h

index 3ca25d4cba1425bd5a379c7c5f8b10e964e23e51..b86389a0bd5fa31b9c42c1e646addf2620b08e2c 100644

--- a/webrtc/p2p/base/p2ptransportchannel.h

+++ b/webrtc/p2p/base/p2ptransportchannel.h

@@ -92,6 +92,7 @@ class P2PTransportChannel : public TransportChannelImpl,

return gathering_state_;

}

void AddRemoteCandidate(const Candidate& candidate) override;

+ void RemoveRemoteCandidate(const Candidate& candidate) override;

// Sets the parameters in IceConfig. We do not set them blindly. Instead, we

// only update the parameter if it is considered set in |config|. For example,

// a negative value of receiving_timeout will be considered "not set" and we