Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 1648813004: Remove candidates when doing continual gathering (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Fix a Windows compiling error Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index 78635e4a56390953917c4b11eb3016b3dcb5f596..ece1bbcfca312d128c41f2e47325572b112547b9 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -85,6 +85,7 @@ class WebRtcVideoEncoderFactory;
namespace webrtc {
class AudioDeviceModule;
class MediaConstraintsInterface;
+typedef rtc::scoped_refptr<IceCandidateInterface> IceCandidateInterfaceRefPtr;
// MediaStream container interface.
class StreamCollectionInterface : public rtc::RefCountInterface {
@@ -417,6 +418,14 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// take the ownership of the |candidate|.
virtual bool AddIceCandidate(const IceCandidateInterface* candidate) = 0;
+ // Removes a group of remote candidates from the ICE agent.
+ // TODO(honghaiz): make it a pure virtual method once all the subclasses have
+ // implemented this method.
+ virtual bool RemoveIceCandidates(
+ const std::vector<IceCandidateInterfaceRefPtr>& candidates) {
+ return false;
+ }
+
virtual void RegisterUMAObserver(UMAObserver* observer) = 0;
// Returns the current SignalingState.
@@ -473,6 +482,12 @@ class PeerConnectionObserver {
// New Ice candidate have been found.
virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0;
+ // Ice candidates have been removed.
+ // TODO(honghaiz): Make this a pure virtual method when all its subclasses
+ // implement it.
+ virtual void OnIceCandidatesRemoved(
+ const std::vector<IceCandidateInterfaceRefPtr>& candidates){};
pthatcher1 2016/03/01 23:51:53 Same here. I don't understand why ref counting is
honghaiz3 2016/03/02 19:06:40 Since we need it in one place, I think we should j
+
// Called when the ICE connection receiving status changes.
virtual void OnIceConnectionReceivingChange(bool receiving) {}

Powered by Google App Engine
This is Rietveld 408576698