Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Side by Side Diff: webrtc/p2p/base/transportchannelimpl.h

Issue 1648813004: Remove candidates when doing continual gathering (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Address Alex's comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/transport.cc ('k') | webrtc/p2p/base/transportcontroller.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 // Handles sending and receiving of candidates. The Transport 69 // Handles sending and receiving of candidates. The Transport
70 // receives the candidates and may forward them to the relevant 70 // receives the candidates and may forward them to the relevant
71 // channel. 71 // channel.
72 // 72 //
73 // Note: Since candidates are delivered asynchronously to the 73 // Note: Since candidates are delivered asynchronously to the
74 // channel, they cannot return an error if the message is invalid. 74 // channel, they cannot return an error if the message is invalid.
75 // It is assumed that the Transport will have checked validity 75 // It is assumed that the Transport will have checked validity
76 // before forwarding. 76 // before forwarding.
77 sigslot::signal2<TransportChannelImpl*, const Candidate&> 77 sigslot::signal2<TransportChannelImpl*, const Candidate&>
78 SignalCandidateGathered; 78 SignalCandidateGathered;
79 sigslot::signal2<TransportChannelImpl*, const Candidates&>
80 SignalCandidatesRemoved;
79 virtual void AddRemoteCandidate(const Candidate& candidate) = 0; 81 virtual void AddRemoteCandidate(const Candidate& candidate) = 0;
82 virtual void RemoveRemoteCandidate(const Candidate& candidate) = 0;
80 83
81 virtual IceGatheringState gathering_state() const = 0; 84 virtual IceGatheringState gathering_state() const = 0;
82 85
83 // DTLS methods 86 // DTLS methods
84 virtual bool SetLocalCertificate( 87 virtual bool SetLocalCertificate(
85 const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) = 0; 88 const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) = 0;
86 89
87 // Set DTLS Remote fingerprint. Must be after local identity set. 90 // Set DTLS Remote fingerprint. Must be after local identity set.
88 virtual bool SetRemoteFingerprint(const std::string& digest_alg, 91 virtual bool SetRemoteFingerprint(const std::string& digest_alg,
89 const uint8_t* digest, 92 const uint8_t* digest,
90 size_t digest_len) = 0; 93 size_t digest_len) = 0;
91 94
92 virtual bool SetSslRole(rtc::SSLRole role) = 0; 95 virtual bool SetSslRole(rtc::SSLRole role) = 0;
93 96
94 // Invoked when there is conflict in the ICE role between local and remote 97 // Invoked when there is conflict in the ICE role between local and remote
95 // agents. 98 // agents.
96 sigslot::signal1<TransportChannelImpl*> SignalRoleConflict; 99 sigslot::signal1<TransportChannelImpl*> SignalRoleConflict;
97 100
98 // Emitted whenever the number of connections available to the transport 101 // Emitted whenever the number of connections available to the transport
99 // channel decreases. 102 // channel decreases.
100 sigslot::signal1<TransportChannelImpl*> SignalConnectionRemoved; 103 sigslot::signal1<TransportChannelImpl*> SignalConnectionRemoved;
101 104
102 private: 105 private:
103 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannelImpl); 106 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannelImpl);
104 }; 107 };
105 108
106 } // namespace cricket 109 } // namespace cricket
107 110
108 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_ 111 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_
OLDNEW
« no previous file with comments | « webrtc/p2p/base/transport.cc ('k') | webrtc/p2p/base/transportcontroller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698