Remove candidates when doing continual gathering

webrtc/p2p/base/candidate.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 151 matching lines @@
   }
   void set_related_address(
       const rtc::SocketAddress & related_address) {
     related_address_ = related_address;
   }
   const std::string& tcptype() const { return tcptype_; }
   void set_tcptype(const std::string& tcptype){
     tcptype_ = tcptype;
   }
 
+  const std::string& transport_name() const { return transport_name_; }
+  void set_transport_name(const std::string& transport_name) {
+    transport_name_ = transport_name;
+  }

[pthatcher1, 2016/03/05 02:14:32]

We should probably put a comment explaining what this is: the transport->name()
of the P2pTransport of this candidate.

[honghaiz3, 2016/03/09 17:40:06]

Done.

+
   // Determines whether this candidate is equivalent to the given one.
   bool IsEquivalent(const Candidate& c) const {
     // We ignore the network name, since that is just debug information, and
     // the priority, since that should be the same if the rest is (and it's
     // a float so equality checking is always worrisome).
     return (component_ == c.component_) && (protocol_ == c.protocol_) &&
            (address_ == c.address_) && (username_ == c.username_) &&
            (password_ == c.password_) && (type_ == c.type_) &&
            (generation_ == c.generation_) && (foundation_ == c.foundation_) &&
            (related_address_ == c.related_address_);
   }
 
+  // Determines whether this candidate can be considered equivalent to the
+  // given one when looking for a matching candidate to remove.
+  bool MatchesForRemoval(const Candidate& c) const {
+    return component_ == c.component_ && protocol_ == c.protocol_ &&
+           address_ == c.address_;
+  }
+
   std::string ToString() const {
     return ToStringInternal(false);
   }
 
   std::string ToSensitiveString() const {
     return ToStringInternal(true);
   }
 
   uint32_t GetPriority(uint32_t type_preference,
                        int network_adapter_preference,
@@ skipping 44 matching lines @@
   std::string username_;
   std::string password_;
   std::string type_;
   std::string network_name_;
   rtc::AdapterType network_type_;
   uint32_t generation_;
   std::string foundation_;
   rtc::SocketAddress related_address_;
   std::string tcptype_;
   uint32_t network_cost_ = 0;
+  std::string transport_name_;

[pthatcher1, 2016/03/05 02:14:32]

Can you make this the first thing (before id_) and add it to the
ToStringInternal?

[honghaiz3, 2016/03/09 17:40:06]

Done. The first thing was foundation.

 };
 
+typedef std::vector<Candidate> Candidates;

[pthatcher1, 2016/03/05 02:14:32]

Same here as before.

[honghaiz3, 2016/03/09 17:40:06]

Done.

+
 // Used during parsing and writing to map component to channel name
 // and back.  This is primarily for converting old G-ICE candidate
 // signalling to new ICE candidate classes.
 class CandidateTranslator {
  public:
   virtual ~CandidateTranslator() {}
   virtual bool GetChannelNameFromComponent(
       int component, std::string* channel_name) const = 0;
   virtual bool GetComponentFromChannelName(
       const std::string& channel_name, int* component) const = 0;
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_P2P_BASE_CANDIDATE_H_