Remove candidates when doing continual gathering

webrtc/p2p/base/port.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/p2p/base/port.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "webrtc/p2p/base/common.h"
 #include "webrtc/p2p/base/portallocator.h"
 #include "webrtc/base/base64.h"
 #include "webrtc/base/crc32.h"
 #include "webrtc/base/helpers.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/messagedigest.h"
+#include "webrtc/base/network.h"
 #include "webrtc/base/scoped_ptr.h"
 #include "webrtc/base/stringencode.h"
 #include "webrtc/base/stringutils.h"
 
 namespace {
 
 // Determines whether we have seen at least the given maximum number of
 // pings fail to have a response.
 inline bool TooManyFailures(
     const std::vector<cricket::Connection::SentPing>& pings_since_last_response,
@@ skipping 155 matching lines @@
 
 void Port::Construct() {
   // TODO(pthatcher): Remove this old behavior once we're sure no one
   // relies on it.  If the username_fragment and password are empty,
   // we should just create one.
   if (ice_username_fragment_.empty()) {
     ASSERT(password_.empty());
     ice_username_fragment_ = rtc::CreateRandomString(ICE_UFRAG_LENGTH);
     password_ = rtc::CreateRandomString(ICE_PWD_LENGTH);
   }
+  network_->SignalInterfaceDown.connect(this, &Port::OnNetworkDown);

[pthatcher1, 2016/02/10 00:01:41]

Should this be OnNetworkInactive?

[honghaiz3, 2016/02/10 19:22:44]

Done.

   LOG_J(LS_INFO, this) << "Port created";
 }
 
 Port::~Port() {
   // Delete all of the remaining connections.  We copy the list up front
   // because each deletion will cause it to be modified.
 
   std::vector<Connection*> list;
 
   AddressMap::iterator iter = connections_.begin();
@@ skipping 413 matching lines @@
                        << " to " << addr.ToSensitiveString();
 }
 
 void Port::OnMessage(rtc::Message *pmsg) {
   ASSERT(pmsg->message_id == MSG_DEAD);
   if (dead()) {
     Destroy();
   }
 }
 
+void Port::OnNetworkDown(const rtc::Network* network) {
+  ASSERT(network == network_);
+  SignalStopped(this);

[pthatcher1, 2016/02/10 00:01:41]

Should we destroy the port as well?  If not, should we just call this
SignalNetworkInactive?

[honghaiz3, 2016/02/10 19:22:44]

Done. Changed to SignalNetworkInactive.
Better not to destroy ports because connections are still using the port. 

+}
+
 std::string Port::ToString() const {
   std::stringstream ss;
   ss << "Port[" << content_name_ << ":" << component_
      << ":" << generation_ << ":" << type_
      << ":" << network_->ToString() << "]";
   return ss.str();
 }
 
 void Port::EnablePortPackets() {
   enable_port_packets_ = true;
@@ skipping 779 matching lines @@
     ASSERT(sent < 0);
     error_ = port_->GetError();
     sent_packets_discarded_++;
   } else {
     send_rate_tracker_.AddSamples(sent);
   }
   return sent;
 }
 
 }  // namespace cricket