Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1647483004: Revert of Adding "first packet received" notification to PeerConnectionObserver. (Closed)

Created:
4 years, 10 months ago by terelius
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding "first packet received" notification to PeerConnectionObserver. (patchset #5 id:80001 of https://codereview.webrtc.org/1581693006/ ) Reason for revert: onFirstMediaPacketReceived() breaks bot. Original issue's description: > Adding "first packet received" notification to PeerConnectionObserver. > > R=glaznev@webrtc.org, pthatcher@webrtc.org, tkchin@webrtc.org > > Committed: https://crrev.com/42265a8cc3b3f3db4aa2c29005aed2fb4393adef > Cr-Commit-Position: refs/heads/master@{#11401} > > Committed: https://crrev.com/08a6eab75e13613183509d91d3892c1db57f6fc5 > Cr-Commit-Position: refs/heads/master@{#11404} TBR=pthatcher@webrtc.org,tkchin@webrtc.org,glaznev@webrtc.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6043f2e5d69da50c4d288e67a7eb9f9bd1eb3dc7 Cr-Commit-Position: refs/heads/master@{#11415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -81 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnection.java View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnectionObserver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnectionObserver.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCPeerConnectionDelegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnection.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 3 chunks +0 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ARDAppClient.m View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
terelius
Created Revert of Adding "first packet received" notification to PeerConnectionObserver.
4 years, 10 months ago (2016-01-28 13:05:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647483004/1
4 years, 10 months ago (2016-01-28 13:05:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 13:06:12 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 13:06:30 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6043f2e5d69da50c4d288e67a7eb9f9bd1eb3dc7
Cr-Commit-Position: refs/heads/master@{#11415}

Powered by Google App Engine
This is Rietveld 408576698