Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: webrtc/video/video_decoder_unittest.cc

Issue 1647163002: Deprecate VideoDecoder::Reset() and remove calls. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove OnInitializeDecoder for video Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_decoder.cc ('k') | webrtc/video/vie_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_decoder_unittest.cc
diff --git a/webrtc/video/video_decoder_unittest.cc b/webrtc/video/video_decoder_unittest.cc
index 4d54a3e53f46f1cd1dc163eb200f03aabebeae5e..b95aa20ee2b71b1a7215961ef2d55a19078512df 100644
--- a/webrtc/video/video_decoder_unittest.cc
+++ b/webrtc/video/video_decoder_unittest.cc
@@ -49,11 +49,6 @@ class VideoDecoderSoftwareFallbackWrapperTest : public ::testing::Test {
return WEBRTC_VIDEO_CODEC_OK;
}
- int32_t Reset() override {
- ++reset_count_;
- return WEBRTC_VIDEO_CODEC_OK;
- }
-
const char* ImplementationName() const override {
return "fake-decoder";
}
@@ -134,20 +129,6 @@ TEST_F(VideoDecoderSoftwareFallbackWrapperTest, ForwardsReleaseCall) {
EXPECT_EQ(2, fake_decoder_.release_count_);
}
-TEST_F(VideoDecoderSoftwareFallbackWrapperTest, ForwardsResetCall) {
- VideoCodec codec = {};
- fallback_wrapper_.InitDecode(&codec, 2);
- fallback_wrapper_.Reset();
- EXPECT_EQ(1, fake_decoder_.reset_count_);
-
- fake_decoder_.decode_return_code_ = WEBRTC_VIDEO_CODEC_FALLBACK_SOFTWARE;
- EncodedImage encoded_image;
- fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1);
- fallback_wrapper_.Reset();
- EXPECT_EQ(2, fake_decoder_.reset_count_)
- << "Reset not forwarded during fallback.";
-}
-
// TODO(pbos): Fake a VP8 frame well enough to actually receive a callback from
// the software decoder.
TEST_F(VideoDecoderSoftwareFallbackWrapperTest,
« no previous file with comments | « webrtc/video/video_decoder.cc ('k') | webrtc/video/vie_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698